Commit graph

7 commits

Author SHA1 Message Date
Chris Peressini
82f61410b6 Change Canccel button class
Used to be `btn-default`, change it to `btn-cancel`
2017-03-14 12:23:44 +00:00
Timothy Andrew
f706a973c2 View-related (and other minor) changes to !5951 based on @rymai's review.
- The `scopes_form` partial can be used in the `admin/applications` view
  as well

- Don't allow partials to access instance variables directly. Instead, pass
  in the instance variables as local variables, and use `local_assigns.fetch`
  to assert that the variables are passed in as expected.

- Change a few instances of `render :partial` to `render`

- Remove an instance of `required: false` in a view, since this is the default

- Inline many instances of a local variable (`ip = 'ip'`) in `auth_spec`
2016-12-16 16:29:32 +05:30
Timothy Andrew
6c809dfae8 Allow creating personal access tokens / OAuth applications with scopes. 2016-12-16 15:08:10 +05:30
Robert Speicher
7a2370f740 Standardize the way we check for and display form errors
- Some views had a "Close" button. We've removed this, because we don't
  want users accidentally hiding the validation errors and not knowing
  what needs to be fixed.
- Some views used `li`, some used `p`, some used `span`. We've
  standardized on `li`.
- Some views only showed the first error. We've standardized on showing
  all of them.
- Some views added an `#error_explanation` div, which we've made
  standard.
2016-04-04 21:37:07 -04:00
Zeger-Jan van de Weg
89154880e5 Save button on app settings now btn-save 2016-01-26 10:05:28 +01:00
Robert Speicher
b9069f31b9 Make the New Application form's error messages visible 2015-04-07 13:01:30 -04:00
Valery Sizov
20028523b5 Application admin scaffold 2015-01-17 15:40:09 -08:00