Commit graph

6 commits

Author SHA1 Message Date
Stan Hu
239743345a Fix GitLab Pages not refreshing upon new content
Due to autoloading and Ruby scoping, the .update file was never being
updated due to this error:

```
NoMethodError: undefined method `pages' for Projects::Settings:Module
        from /opt/gitlab/embedded/service/gitlab-rails/app/services/projects/update_pages_configuration_service.rb:50:in `pages_update_file'
        from /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:157:in `pages_update_file'
        from (irb):6
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/console.rb:110:in `start'
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/console.rb:9:in `start'
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/commands_tasks.rb:68:in `console'
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands.rb:17:in `<top (required)>'
        from bin/rails:9:in `require'
```

This error was caught and discarded quietly. This fix exercises this code and fixes the scope problem.

Closes gitlab-com/infrastructure#1058
2017-02-01 23:09:12 +00:00
Kamil Trzcinski
c6723ed3e0 Updated configuration saving 2017-01-31 22:53:58 +00:00
Kamil Trzcinski
d3b8284876 Pages domain model specs 2017-01-31 22:53:57 +00:00
Kamil Trzcinski
e5e2e7b703 Fix the remove_pages 2017-01-31 22:53:57 +00:00
Kamil Trzcinski
13b6bad17e Implement extra domains and save pages configuration 2017-01-31 22:53:57 +00:00
Kamil Trzcinski
5f7257c27d Initial work on GitLab Pages update 2017-01-31 22:53:57 +00:00