Commit graph

12 commits

Author SHA1 Message Date
Andrew Newdigate
56ae34e49b Adds metrics to measure database transactions
Currently we don't have good insight into the affect of Rails
transaction blocks on the application. If these blocks are held open for
extended periods, they can have detrimental effects on the application.

This change will allow us to track these transactions, with the aim
of reducing their duration.
2019-06-28 12:46:51 +02:00
Kamil Trzciński
650f40865e Forbid the use of #reload and prefer #reset
The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.

The `#reset` seems to solve exactly that case.
2019-04-15 13:05:14 +02:00
gfyoung
c858f70d07 Enable frozen string for lib/gitlab/*.rb 2018-10-22 07:00:50 +00:00
🙈 jacopo beschi 🙉
c6b1043e9d Resolve "Make a Rubocop that forbids returning from a block" 2018-04-18 09:19:40 +00:00
Jacopo
181cd299f9 Adds Rubocop rule for line break after guard clause
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
2017-11-16 17:58:29 +01:00
Robert Speicher
170fef0bd3 Merge branch 'dm-meer-blauw-op-straat' into 'master'
Enable (and disable) more RuboCops

See merge request !9432
2017-02-23 17:19:28 +00:00
Douwe Maan
215228b477 Enable Performance/RedundantBlockCall 2017-02-23 09:31:57 -06:00
Grzegorz Bizon
ca378aa34c Fix Rubocop offense in OptimisticLocking module 2017-02-23 14:56:27 +01:00
Grzegorz Bizon
ed98680678 Process skipped jobs in the pipeline when retrying it 2017-02-23 11:44:49 +01:00
Kamil Trzcinski
2822526e7b Make retry_lock to not be infinite 2016-10-27 12:34:35 +01:00
Kamil Trzcinski
47b2add4f6 Add tests for optimistic locking 2016-10-26 11:37:23 +02:00
Kamil Trzcinski
5d7ee7a1b6 Use optimistic locking 2016-10-26 11:37:23 +02:00