kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
55324 commits 1 branch 0 tags 899 MiB
Commit graph

25 commits

Author SHA1 Message Date
Robert Speicher
c5a88df6b7 Require rubocop-rspec in the correct location 
Resolves the `codeclimate` CI failure
 2017-06-14 17:08:34 -05:00
Robert Speicher
69ad827e82 Add a custom RSpec/SingleLineHook cop 
This cop adds an offense when `before`, `after`, or `around` are used as
single-line blocks.
 2017-06-14 13:16:44 -05:00
blackst0ne
bc00806a4e Add database helpers 'add_timestamps_with_timezone' and 'timestamps_with_timezone' 2017-06-13 22:44:13 +11:00
Yorick Peterse
5819ca1a24
Added Cop to blacklist polymorphic associations 
One should really use a separate table instead of using polymorphic
associations.

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11168 for
more information.
 2017-06-07 17:36:55 +02:00
blackst0ne
a544e46bb0 Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers 2017-06-07 09:45:16 +11:00
Yorick Peterse
cd74c1434e
Added Cop to blacklist the use of serialize 
This Cop blacklists the use of ActiveRecord's "serialize" method, except
for cases where we already use this.
 2017-05-31 14:03:37 +02:00
Rémy Coutable
187e6c8d7c New Migration/UpdateColumnInBatches cop 
Signed-off-by: Rémy Coutable <remy@rymai.me>
 2017-05-29 11:28:23 +02:00
Robert Speicher
b9fa17d87b Add AddColumnWithDefaultToLargeTable cop 2017-04-28 15:55:55 -05:00
Robert Speicher
9c27c90b4a Rename AddColumnWithDefault to ReversibleAddColumnWithDefault 
We're going to add another cop that deals with another aspect of
`add_column_with_default`, so we need to separate them.
 2017-04-28 15:55:53 -05:00
Robert Speicher
bbdaf982e6 Refactor the AddColumnWithDefault cop to use node matchers 2017-04-28 15:55:53 -05:00
blackst0ne
9997c58fc0 Add remove_concurrent_index to database helper 2017-04-06 09:53:57 +11:00
Douwe Maan
5d9762b3b5 Add cop to ensure reversibility of add_concurrent_index 2017-03-07 10:09:01 -06:00
Sean McGivern
811e598f60 Enable and autocorrect the CustomErrorClass cop 2017-03-01 15:28:10 +00:00
Sean McGivern
8dd097a915 Add RuboCop cop for custom error classes 
From the Ruby style guide:

    # bad
    class FooError < StandardError
    end

    # okish
    class FooError < StandardError; end

    # good
    FooError = Class.new(StandardError)

This cop does that, but only for error classes (classes where the
superclass ends in 'Error'). We have empty controllers and models, which
are perfectly valid empty classes.
 2017-03-01 10:53:10 +00:00
Douwe Maan
56de781a2c Revert "Enable Style/DotPosition" 
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.

# Conflicts:
#	.rubocop.yml
#	.rubocop_todo.yml
#	lib/gitlab/ci/config/entry/global.rb
#	lib/gitlab/ci/config/entry/jobs.rb
#	spec/lib/gitlab/ci/config/entry/factory_spec.rb
#	spec/lib/gitlab/ci/config/entry/global_spec.rb
#	spec/lib/gitlab/ci/config/entry/job_spec.rb
#	spec/lib/gitlab/ci/status/build/factory_spec.rb
#	spec/lib/gitlab/incoming_email_spec.rb
 2017-02-23 09:33:19 -06:00
Douwe Maan
1fe7501b49 Revert "Prefer leading style for Style/DotPosition" 
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
 2017-02-23 09:33:05 -06:00
Douwe Maan
206953a430 Prefer leading style for Style/DotPosition 2017-02-23 09:32:22 -06:00
Douwe Maan
b7d8df503c Enable Style/MutableConstant 2017-02-23 09:31:56 -06:00
Douwe Maan
3dadf306dd Enable Style/DotPosition 2017-02-23 09:31:56 -06:00
Yorick Peterse
766060bcdf
Enforce use of add_concurrent_foreign_key 
This adds a Rubocop rule to enforce the use of
add_concurrent_foreign_key instead of the regular add_foreign_key
method. This cop has been disabled for existing migrations so we don't
need to change those.
 2017-02-10 21:51:09 +01:00
Robert Speicher
f57989c2ed Add a spec for our custom GemFetcher cop 2017-02-09 12:11:19 -05:00
Douwe Maan
b0afed1aac Explicitly require rubocop migration_helpers 2017-02-08 16:47:48 -06:00
Douwe Maan
abc9548f8a Add cop that checks if add_column_with_default is used with up/down methods 2017-02-08 16:47:48 -06:00
Adam Pahlevi
78a3bba62e cop for gem fetched from a git source 
code fix for aesthetic & conventions

remove unused proc
 2017-01-31 09:24:15 +07:00
Yorick Peterse
c740445ad3
Added RuboCop cops for checking DB migrations 
There are currently two cops for this:

* Migration/AddIndex: checks if indexes are added concurrently
* Migration/ColumnWithDefault: checks if columns with default values are
  added in a concurrent manner

Both cops are fairly simple and make no attempt at correcting the code
as this is quite hard to do (e.g. modifications may need to be applied
in various places in the same file). They however should provide enough
to catch people ignoring the comments in generated migrations telling
them to use add_concurrent_index or add_column_with_default.
 2016-06-29 14:14:02 +02:00