Commit Graph

8 Commits

Author SHA1 Message Date
Timothy Andrew 3c88a7869b Implement review comments for !12445 from @godfat and @rymai.
- Use `GlobalPolicy` to authorize the users that a non-authenticated user can
  fetch from `/api/v4/users`. We allow access if the `Gitlab::VisibilityLevel::PUBLIC`
  visibility level is not restricted.

- Further, as before, `/api/v4/users` is only accessible to unauthenticated users if
  the `username` parameter is passed.

- Turn off `authenticate!` for the `/api/v4/users` endpoint by matching on the actual
  route + method, rather than the description.

- Change the type of `current_user` check in `UsersFinder` to be more
  compatible with EE.
2017-06-30 13:06:03 +00:00
Eric Eastwood ea090291bb Rename "Slash commands" to "Quick actions"
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070

Deprecate "chat commands" in favor of "slash commands"

We looked for things like:

 - `slash commmand`
 - `slash_command`
 - `slash-command`
 - `SlashCommand`
2017-06-15 09:01:56 -05:00
Felipe Artur 60c121ebc2 Backport permissions and multi-line array to CE 2017-04-07 10:53:29 +01:00
http://jneen.net/ f7a111e976 use policies to protect sending email 2017-03-09 11:49:53 -08:00
http://jneen.net/ 0ea04cc5bf use the policy stack to protect logins 2017-03-09 11:49:52 -08:00
http://jneen.net/ d9cfed07cd add User#internal? and some global permissions 2017-03-09 11:49:52 -08:00
http://jneen.net/ b7d3000013 line break after guard clause 2016-08-30 11:39:22 -07:00
http://jneen.net/ 9a0ea13501 factor in global permissions 2016-08-30 11:39:22 -07:00