Commit Graph

25 Commits

Author SHA1 Message Date
Andreas Brandl dd1d13b859 Extract repeated logic into #avatar_icon_for.
This essentially allows to pass both user and email, so that we can
either prefer the user to retrieve the avatar or (if user is not
present) fall back to the email lookup.
2018-02-13 18:04:53 +01:00
Andreas Brandl c641dff094 Explicit use of avatar_icon_* calls depending on situation.
We want to drop the generic #avatar_icon helper that supports both an email
and a user object being passed in. Instead, we want to explicitly use the #avatar_icon_for_user
and #avatar_icon_for_email helpers depending on what we have at hand.
This allows us to avoid unnecessary database queries (e.g. call
User.find_by_any_email if we already have the user).

In situations like here, this makes it less convenient to use.
2018-02-13 18:04:51 +01:00
Andreas Brandl be231d2165 Use more specific #avatar_icon_for_user.
Whenever we already deal with a User object, let's use the more specific
method avatar_icon_for_user.
2018-02-13 18:04:51 +01:00
Christiaan Van den Poel 7edbc0f8c8 Fix job count in pipeline success mail 2017-12-18 09:13:46 +00:00
Gustav Ernberg 3d3e043ce4 Remove unnecessary alt-texts from pipeline emails 2017-10-02 22:19:17 +02:00
Sean McGivern 1c4262156f Fix avatar images in pipeline emails 2017-06-20 15:42:10 +01:00
Toon Claes 717547e840 Clearly show who triggered the pipeline in email
Show who triggered the pipeline. And also show the commit committer if
it's different from the author.
2017-04-06 07:08:38 +02:00
Alexis Reigel f0766fdefa extract pipeline mails layout 2017-02-22 12:22:52 +01:00
Kushal Pandya d15448632a HAMLLint: Fix `UnnecessaryStringOutput` offences 2017-01-24 10:09:28 -08:00
Kushal Pandya fb3e365412 HAMLLint: Fix `SpaceInsideHashAttributes` offences 2016-12-31 11:58:36 +05:30
Kushal Pandya 71dc50f048 HAMLLint: fix `AltText` offences 2016-12-31 11:43:08 +05:30
Kamil Trzcinski d865aedafc Introduce `Ci::Stage`, right now this is artificial object that is build dynamically. 2016-12-06 14:13:21 +01:00
tauriedavis bab98d2979 17492 Update link color for more accessible contrast 2016-11-07 11:06:48 -08:00
Stan Hu 83b570676b Use Hash rocket syntax to maintain Ruby 2.1 compatibility
Builds in Ruby 2.1 specs were failing in master: https://gitlab.com/gitlab-org/gitlab-ce/builds/5258614

Closes #23498
2016-10-18 19:20:12 -07:00
Lin Jen-Shin 29a6f0d28b Introduce more GitLab routing helpers, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6019#note_16852207
2016-10-14 03:33:49 +08:00
Mike Greiling 36aea928a4 invert if statement order 2016-10-13 00:18:00 -05:00
Mike Greiling 5c36905a75 de-duplicate project namespace markup 2016-10-12 17:42:56 -05:00
Lin Jen-Shin 16e6431c83 Use helpers from GitlabRoutingHelper, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6019#note_16832930
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6019#note_16832936
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6019#note_16833033
2016-10-13 01:45:46 +08:00
Lin Jen-Shin c33e2f0ae9 New hash syntax, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6019#note_16832366
2016-10-13 01:23:05 +08:00
Mike Greiling 355ffec763 add message subject to the title tag 2016-10-08 01:28:17 -05:00
Mike Greiling 6622385601 manually generate XHTML doctype since haml :format config cannot be overridden 2016-10-08 01:28:11 -05:00
Mike Greiling 1fe0861051 remove corporate address from email footer and add reference to domain of origin 2016-10-07 17:05:31 -05:00
Mike Greiling 60caeb14a7 update subject and email header message 2016-10-06 10:09:24 -05:00
Mike Greiling 5cd95549d0 add pipeline succeeded email notification 2016-10-05 23:07:00 -05:00
Lin Jen-Shin 4add6ca6ec Try to integrate the email into notification system 2016-09-13 19:09:53 +08:00
Renamed from app/views/notify/pipeline_succeeded_email.html.haml (Browse further)