Commit Graph

14 Commits

Author SHA1 Message Date
gfyoung 93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
Rémy Coutable 3a2abc1d50
Enable the Layout/ExtraSpacing cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-01-24 13:05:45 +01:00
Zeger-Jan van de Weg 30b4ce940d
Remove Git circuit breaker
Was introduced in the time that GitLab still used NFS, which is not
required anymore in most cases. By removing this, the API it calls will
return empty responses. This interface has to be removed in the next
major release, expected to be 12.0.
2018-10-10 09:08:18 +02:00
George Tsiolis 124cece3b3 Include private contributions in user contribution graph 2018-09-07 15:08:55 +00:00
Stan Hu df54458a93 Truncate filenames created by bin/changelog to 140 characters 2018-07-11 10:15:22 -07:00
Jacob Vosmaer (GitLab) dcdcbfa40b Improve shelling out in bin/changelog 2018-06-25 21:32:00 +00:00
Bob Van Landuyt f1ae1e39ce Move the circuitbreaker check out in a separate process
Moving the check out of the general requests, makes sure we don't have
any slowdown in the regular requests.

To keep the process performing this checks small, the check is still
performed inside a unicorn. But that is called from a process running
on the same server.

Because the checks are now done outside normal request, we can have a
simpler failure strategy:

The check is now performed in the background every
`circuitbreaker_check_interval`. Failures are logged in redis. The
failures are reset when the check succeeds. Per check we will try
`circuitbreaker_access_retries` times within
`circuitbreaker_storage_timeout` seconds.

When the number of failures exceeds
`circuitbreaker_failure_count_threshold`, we will block access to the
storage.

After `failure_reset_time` of no checks, we will clear the stored
failures. This could happen when the process that performs the checks
is not running.
2017-12-08 09:11:39 +01:00
Zeger-Jan van de Weg 2622a6de59
Add Performance category to the changelog
Resolves gitlab-org/gitlab-ce#36417
2017-10-13 12:45:56 +02:00
Robert Speicher 4ef10795ce Fix Layout/SpaceBeforeBlockBraces violation in bin/changelog_spec 2017-08-10 19:22:59 -04:00
Jacopo eb2b895a20 Let's start labeling our CHANGELOG entries
Added the type attribute to a CHANGELOG entry. When you create a new
entry the software asks for the category of the change and sets the
associated type in the file.
2017-07-22 11:19:56 +02:00
Rémy Coutable bdf5b6adc3
Enable the RSpec/ExpectOutput cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-18 18:56:26 +02:00
Robert Speicher 813fd6f675 DRY up the specs for bin/changelog 2016-11-03 17:35:06 +00:00
Robert Speicher 895673733a Add a `--force` option to bin/changelog 2016-11-02 22:15:20 +00:00
Robert Speicher 5acb3230ef Add specs for ChangelogOptionParser in bin/changelog 2016-10-31 14:56:20 +00:00