Kamil Trzcinski
aef6214c42
Validate only and except regexp
...
Currently the RegexpError can be raised when processing next stage which leads to 500 in different places of code base.
This adds early check that regexps used in only and except are valid.
2016-06-17 11:52:22 +02:00
Kamil Trzcinski
006b650988
Merge remote-tracking branch 'origin/master' into environments-and-deployments
...
# Conflicts:
# db/schema.rb
2016-06-14 16:19:29 +02:00
Kamil Trzcinski
975e388751
Merge remote-tracking branch 'origin/master' into environments-and-deployments
...
# Conflicts:
# lib/ci/gitlab_ci_yaml_processor.rb
2016-06-14 14:53:10 +02:00
Kamil Trzcinski
3f5819fb7a
Merge remote-tracking branch 'origin/master' into artifacts-expire-date
2016-06-14 14:49:59 +02:00
Grzegorz Bizon
30e946ce8a
Validate ci config entry value before processing nodes
2016-06-14 11:28:20 +02:00
Grzegorz Bizon
59eeec3ff8
Make method that composes ci config entry private
2016-06-14 10:48:51 +02:00
Grzegorz Bizon
11c0d02283
Simplify ci config node factory
2016-06-13 09:58:35 +02:00
Grzegorz Bizon
7c8f3b0cfc
Duplicate CI config node factory on class level
2016-06-13 08:50:12 +02:00
Grzegorz Bizon
cc373a3550
Add factory for fabricating new ci config nodes
2016-06-10 14:01:07 +02:00
Grzegorz Bizon
5abfc7fa71
Define ci entry accessor instead of method_missing
2016-06-10 11:32:49 +02:00
Grzegorz Bizon
12080ba150
Simplify new ci config entry class interface
2016-06-10 11:26:03 +02:00
Grzegorz Bizon
828a15bccd
Rename method used to allow node in Ci config
2016-06-10 10:49:47 +02:00
Grzegorz Bizon
d7e1251161
Rename method that returns allowed nodes in Ci config
2016-06-09 14:59:59 +02:00
Grzegorz Bizon
99ee39bf6c
Add comments to new CI config classes and modules
2016-06-09 13:15:54 +02:00
Grzegorz Bizon
20ccd4465b
Do not require Ci config node to have a hash value
2016-06-09 12:35:24 +02:00
Grzegorz Bizon
6a319fd287
Make it possible configure Ci entry description
2016-06-09 10:53:56 +02:00
Grzegorz Bizon
d9d5042fd9
Extract method that composes new Ci config entry
2016-06-09 10:28:44 +02:00
Grzegorz Bizon
33cd090b93
Move new Ci config configurable DSL to concern
2016-06-09 10:08:49 +02:00
Grzegorz Bizon
48a59c1a8b
Rename BeforeScript to Script in new Ci config
2016-06-08 13:22:39 +02:00
Grzegorz Bizon
5065612a0a
Add minor improvements in new Ci config design
2016-06-08 13:01:44 +02:00
Grzegorz Bizon
87fe50f2a0
Delegate Ci config entry value to single method
2016-06-08 12:32:56 +02:00
Grzegorz Bizon
2b48da22ca
Merge branch 'master' into refactor/ci-config-add-global-entry
...
* master: (285 commits)
Bump recaptcha gem to 3.0.0 to remove deprecated stoken support
Load knapsack in Rakefile only when is bundled
Add License Finder information to contribution acceptance criteria.
Add LGPLv2 to license whiltelist
Instrument `RepositoryCheck::SingleRepositoryWorker` manually
Bump nokogiri to 1.6.8
Fix alignment of wiki top area
Update charcoal theme colors
Update nav link font size and spacing; fix hamburger icon
Fix control btn position
Remove todos count tests in nav
Test impersonation using img data attribute instead of username
Implement compact side nav
Fix knapsack for master
Align links and tabs
Add scrolling tabs to code subnav
Finish styling sub nav
Updated colors
Fixed failing tests
CHANGELOG item
...
Conflicts:
lib/gitlab/ci/config.rb
spec/lib/gitlab/ci/config_spec.rb
2016-06-08 11:38:56 +02:00
Grzegorz Bizon
70bda3e89b
Implement script in Ci config and use in legacy one
2016-06-07 14:23:47 +02:00
Grzegorz Bizon
c2d6d61dac
Add DSL for adding nodes in Ci config interface
2016-06-07 13:20:07 +02:00
Grzegorz Bizon
df25c19699
Use Ci config validation helpers only where needed
2016-06-07 12:58:32 +02:00
Grzegorz Bizon
5ef104df59
Improve Ci config loader by changing method signature
2016-06-07 12:53:46 +02:00
Grzegorz Bizon
6bd67f5212
Do not process new Ci config entry when invalid
2016-06-07 12:48:26 +02:00
Grzegorz Bizon
e8f995ef26
Pass root Ci config entry to each subsequent entry
2016-06-07 12:13:22 +02:00
Grzegorz Bizon
69a3755c5a
Add Ci config entry that implements Null Object
2016-06-07 11:58:02 +02:00
Grzegorz Bizon
b95c60a071
Do not process Ci config node when node is a leaf
2016-06-07 11:26:39 +02:00
Grzegorz Bizon
940763e0e7
Use CI config errors from new processor in legacy one
2016-06-06 20:56:58 +02:00
Grzegorz Bizon
a3c0745514
Collect errors from all nodes in new CI config
2016-06-06 11:59:25 +02:00
Grzegorz Bizon
6dbd1c86a8
Validate new before script CI configuration entry
2016-06-06 11:33:45 +02:00
Grzegorz Bizon
251dd571df
Extract CI config validation helpers to mixin
2016-06-06 11:05:15 +02:00
Grzegorz Bizon
8048dcc8e6
Implement CI configuration nodes tree processing
2016-06-06 10:43:11 +02:00
Grzegorz Bizon
7f2f683eeb
Rename ci config module that holds nodes to Node
2016-06-06 09:24:16 +02:00
Grzegorz Bizon
6609589b93
Add ci config global and before_script entries
2016-06-06 09:05:00 +02:00
Grzegorz Bizon
23030439c2
Rename class that loads CI configuration to Loader
2016-06-06 08:20:55 +02:00
Grzegorz Bizon
d2b708ac43
Extract CI config YAML parser to a separate class
...
With this approach it would be easier to add different sources of
configuration, that we do not necessairly have to be in YAML format.
2016-06-03 21:10:50 +02:00