Commit graph

6 commits

Author SHA1 Message Date
Yorick Peterse
766060bcdf
Enforce use of add_concurrent_foreign_key
This adds a Rubocop rule to enforce the use of
add_concurrent_foreign_key instead of the regular add_foreign_key
method. This cop has been disabled for existing migrations so we don't
need to change those.
2017-02-10 21:51:09 +01:00
Robert Speicher
f57989c2ed Add a spec for our custom GemFetcher cop 2017-02-09 12:11:19 -05:00
Douwe Maan
b0afed1aac Explicitly require rubocop migration_helpers 2017-02-08 16:47:48 -06:00
Douwe Maan
abc9548f8a Add cop that checks if add_column_with_default is used with up/down methods 2017-02-08 16:47:48 -06:00
Adam Pahlevi
78a3bba62e cop for gem fetched from a git source
code fix for aesthetic & conventions

remove unused proc
2017-01-31 09:24:15 +07:00
Yorick Peterse
c740445ad3
Added RuboCop cops for checking DB migrations
There are currently two cops for this:

* Migration/AddIndex: checks if indexes are added concurrently
* Migration/ColumnWithDefault: checks if columns with default values are
  added in a concurrent manner

Both cops are fairly simple and make no attempt at correcting the code
as this is quite hard to do (e.g. modifications may need to be applied
in various places in the same file). They however should provide enough
to catch people ignoring the comments in generated migrations telling
them to use add_concurrent_index or add_column_with_default.
2016-06-29 14:14:02 +02:00