Commit graph

8 commits

Author SHA1 Message Date
Mario de la Ossa
eaada9d706 use Gitlab::UserSettings directly as a singleton instead of including/extending it 2018-02-02 18:39:55 +00:00
Sean McGivern
5883ce95ef current_application_settings belongs on Gitlab::CurrentSettings
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
2017-08-31 13:38:33 +01:00
Maxim Rydkin
fa030cbc85 replace is_spam? with spam? 2017-08-29 11:14:42 +03:00
Robert Speicher
260c8da060 Whitelist or fix additional Gitlab/PublicSend cop violations
An upcoming update to rubocop-gitlab-security added additional
violations.
2017-08-14 12:14:11 -04:00
Rémy Coutable
d40e1f547e Enable the Style/TrailingCommaInLiteral cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Robert Speicher
d834ee2c70 Reduce duplication in AkismetService 2016-09-20 08:19:32 +03:00
Patricio Cano
5994c11910 Further refactor and syntax fixes. 2016-08-15 17:20:57 -05:00
Patricio Cano
43e756d4ea Refactored AkismetHelper into AkismetService and cleaned up Spammable
- Refactored SpamCheckService into SpamService
2016-08-15 13:18:15 -05:00