Commit Graph

15 Commits

Author SHA1 Message Date
gfyoung 93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
Stan Hu eafccaad73 Fix Bitbucket Server import not allowing personal projects
Bitbucket Server places personal projects in a namespace called
`~username`. This change allows those projects and also strips
them from the GitLab namespace.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53419
2019-01-28 13:06:27 -08:00
Stan Hu 660dcd5b7c Fix Bitbucket Server importer error handling
The importer would display a 500 error page if you attempted to import
using a non-existent DNS entry. This commit rescues known network issues
and consolidates them into
BitbucketServer::Connection::ConnectionError`.  The previous error
handling in the paginator doesn't work because it returns a lazy
collection.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56154
2019-01-12 22:14:08 -08:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Tiago Botelho 4bd8a427d4
Removes all the irrelevant import related code and columns
Clears the import related columns and code from the Project
model over to the ProjectImportState model
2018-11-27 12:58:13 +00:00
Stan Hu 5b6d5301d9 Paginate Bitbucket Server importer projects
To prevent delays in loading the page and reduce memory usage, limit the
number of projects shown at 25 per page.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/50021
2018-11-07 11:37:46 -08:00
Stan Hu 3f715bb438 Consolidate server errors and add specs 2018-07-26 23:05:22 -07:00
Stan Hu 079b490ad2 Fix failing specs 2018-07-26 21:55:23 -07:00
Stan Hu 6a992fb4c5 Add missing stubbed parameter 2018-07-17 21:07:00 -07:00
Stan Hu 0936bff496 Finish specs for spec/controllers/import/bitbucket_server_controller_spec.rb 2018-07-09 16:04:41 -07:00
Stan Hu 589a28889a Test server connection error 2018-07-08 14:57:30 -07:00
Stan Hu ed166b791f Add spec when project can't be saved 2018-07-08 14:49:09 -07:00
Stan Hu 4c5085f68d Add spec for project not found 2018-07-08 07:49:47 -07:00
Stan Hu 5d7e130e64 Add more specs and fix some typos 2018-07-08 07:44:33 -07:00
Stan Hu 24ac81cca6 Add initial specs for app/controllers/import/bitbucket_server_controller.rb 2018-07-08 07:38:07 -07:00