Commit Graph

16 Commits

Author SHA1 Message Date
Rémy Coutable f49aeacdd0
Merge branch 'fix-misspellings-app-comments' into 'master'
Fix misspellings in app/spec comments

See merge request gitlab-org/gitlab-ce!25517
2019-02-26 12:25:01 +01:00
Michael Kozono cae2c33681
Revert "Merge branch 'fix-misspellings-app-comments' into 'master'"
This reverts commit 9202bbd129, reversing
changes made to 4b282e9ce1.
2019-02-25 12:53:09 -08:00
Takuya Noguchi bbf479a36c Fix misspellings in app/spec comments
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2019-02-25 17:25:19 +09:00
Jan Provaznik 4ded04119c Allow pass additional options to use_fast_destroy
These options are then used when setting before destroy callback.
2018-12-06 22:00:19 +01:00
Jan Provaznik 239fdc78b1 Use FastDestroy for deleting uploads
It gathers list of file paths to delete before destroying
the parent object. Then after the parent_object is destroyed
these paths are scheduled for deletion asynchronously.

Carrierwave needed associated model for deleting upload file.
To avoid this requirement, simple Fog/File layer is used directly
for file deletion, this allows us to use just a simple list of paths.
2018-12-06 22:00:19 +01:00
George Tsiolis 733ae94921 Fix typos in comments and specs 2018-11-01 08:59:20 +02:00
Yorick Peterse 9606dbbb03
Whitelist existing destroy_all offenses
This whitelists all existing places where we use "destroy_all".
2018-08-16 17:29:37 +02:00
gfyoung 15b878e27e Enable more frozen string in app/models/**/*.rb
Partially addresses #47424.
2018-08-07 00:37:36 -07:00
Shinya Maeda ecf8287ce5 Use prepend: true to evaluate always perform_fast_destroy than dependent: :destroy 2018-05-04 20:47:23 +09:00
Shinya Maeda dffc2cb7a3 Fix typo in fast_destroy_all 2018-05-03 20:12:25 +09:00
Shinya Maeda c80949fdcd Simplify FastDestroyAll module 2018-05-03 17:08:05 +09:00
Shinya Maeda 18ba092aec Fix typo for comments in fast_destroy_all 2018-05-03 15:49:02 +09:00
Shinya Maeda 45dc7ae2d2 Clean up build_trace_chunk 2018-05-03 14:57:15 +09:00
Shinya Maeda 2fde2d6524 Fix static analysys 2018-05-02 21:30:39 +09:00
Shinya Maeda 9e65dc5377 Introduce `use_fast_destroy` helper for parent associations. Rename method names in build_trace_chunks. Forbid `destroy` method when `FastDestroyAll` included. 2018-05-02 15:55:55 +09:00
Shinya Maeda 1d53918b62 Introduces `FastDestroyAll` module 2018-05-01 17:06:44 +09:00