Commit graph

5 commits

Author SHA1 Message Date
GitLab Bot
40d3d57413 Add latest changes from gitlab-org/gitlab@master 2019-09-13 18:06:03 +00:00
ddavison
015b61b1dc
Change element_with_pattern cop to not use quotes
Using quotes within string validations can be messy. Let's
use  a typical CSS selector for an unquoted attribute

Update the cop spec to validate appropriate new message
2019-07-10 16:10:28 -07:00
ddavison
390e0d8906
Introduce data-qa-selector to supplant .qa-class
In order to break away from using CSS classes as
our primary method of element identification, we
need to provide the ability to search for data
attributes.

Make Test::Sanity::Selectors now work

Utilize regex to match on literal strings of the element name

Suggest the data-qa-selector pattern vs the qa-

Add data-qa-selector to login page to start

We need a page that is heavily used in order to be
confident that this functionality works. Let's start
with the Login page

Use appropriate HAML data tag practices
2019-07-10 16:09:43 -07:00
ddavison
7d5b68d837
Implement dynamic validation on QA Pages
Elements now have the ability to be required on pages or not
Currently using the default wait mechanism
Altered the ElementWithPattern Cop to fit new splat for init
2019-05-20 12:35:51 -07:00
Rémy Coutable
02c47f2f73
Add a new QA::ElementWithPattern cop
This cop forbids the use of `element :foo, 'pattern'` and
`element :bar, /pattern/` in QA files.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-10-15 14:28:03 +02:00