Commit Graph

22 Commits

Author SHA1 Message Date
Rémy Coutable 8f8fd34231 Use a new RspecFlakyListener to detect flaky specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-11 14:55:10 +02:00
Robert Speicher c8b802471b Enable the RSpec/HookArgument cop and auto-correct offenses 2017-08-10 19:29:42 -04:00
Bob Van Landuyt 7de6f742dc Use `broken_storage` in the fs_shards_spec. 2017-08-07 13:30:11 +02:00
Bob Van Landuyt 3598e60bf2 Add a Circuitbreaker for storage paths 2017-08-04 15:38:48 +02:00
Pawel Chojnacki 7ce0a61a99 use `.zero?` instead of `== 0` 2017-07-26 13:23:27 +02:00
Pawel Chojnacki 895e1b3ed1 Stop abusing subject to store results,
+ add helper methods to cleanup fs_shards metrics
2017-07-26 00:28:13 +02:00
Pawel Chojnacki 2286879583 Ensure test files are deleted after tests 2017-07-25 14:19:09 +02:00
Ben Kochie 86cbef4df4 Add unit to latency metrics.
Add `seconds` unit to latency metrics based on uptream naming
convention[0].

[0]: https://prometheus.io/docs/practices/naming/#metric-names
2017-07-12 14:48:46 +02:00
Paul Charlton cb3b4a15e6 Support multiple Redis instances based on queue type 2017-07-11 03:35:47 +00:00
Michael Kozono 912613c41b Reduce 28 test runs to 4
14 to 2, but these shared examples are used twice. This was already done in another context further down the file.
2017-06-30 09:00:07 -07:00
Michael Kozono 53c409cb07 Rspec/AroundBlock doesn’t know about rspec-retry 2017-06-29 16:54:25 -07:00
Michael Kozono 790c740cce Increase CI retries to 4 for these examples
By default it is 2 tries in CI.
2017-06-29 16:54:25 -07:00
Pawel Chojnacki d26573c6e3 Make PrometheusTextFormat return proper output terminated with '\n'
remove file dangling after rebase
2017-06-02 19:48:39 +02:00
Pawel Chojnacki 6a67148ed3 Make production settings fixture use Gitlab::CurrentSettings.current_application_settings
small code formatting changes
2017-06-02 19:46:29 +02:00
Pawel Chojnacki c86e1437eb Make fixture message more descriptive
+ use strip_heredoc to make the text in tests much more readable
2017-06-02 19:46:29 +02:00
Pawel Chojnacki ae8f7666e5 Add prometheus text formatter
+ rename controler method to #index from #metrics
 + remove assertion from nullMetric
2017-06-02 19:45:58 +02:00
Pawel Chojnacki a0497a7bc0 Move helpers to spec file, use const's instead of helper methods 2017-05-25 21:59:57 +02:00
Pawel Chojnacki 8067efdf3d Make the test cases more readable and fix to_s coercion problem 2017-05-23 14:46:37 +02:00
Pawel Chojnacki 1f10a3c224 Stop skipping tests if local dependencies are not found 2017-05-22 19:44:54 +02:00
Pawel Chojnacki 6ced4d138e Fix transient CI errors by increasing command execution timeouts from 1s to 30s
+ actually make local tests correctly detect wether 'timeout' or 'gtimeout' is available
2017-05-17 16:22:47 +02:00
Pawel Chojnacki cba965eba4 Set minimum latency to be non-negative number.
Sometimes the tests run so fast latency is calculated as 0.
This causes transient failures in our CI.
2017-05-05 11:34:01 +02:00
Sean McGivern 5069682d8e Enable RSpec/FilePath cop
- Ignore JS fixtures
- Ignore qa directory
- Rewrite concern specs to put concern name first
2017-04-26 12:50:32 +01:00