Lin Jen-Shin
|
a4ef4244d4
|
Preserve note_type and position for notes from emails
Closes #23208
|
2016-10-20 16:18:53 +08:00 |
Lin Jen-Shin
|
176fa21cb7
|
raise UnknownIncomingEmail when there's no mail_key:
So that we don't have to pretend that CreateNoteHandler
could handle a nil mail_key. Also, since NilClass#=~ would
just return nil for any regular expression, we could just
match it without checking nilness.
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3363#note_12566407
|
2016-06-20 19:15:54 +08:00 |
Lin Jen-Shin
|
0671db52a8
|
Use keyword args to be more clear:
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3363#note_12566374
|
2016-06-20 19:11:42 +08:00 |
Lin Jen-Shin
|
09c38e46e5
|
Only pass item name
|
2016-06-15 20:10:16 +08:00 |
Lin Jen-Shin
|
9417814970
|
More space for private concern
|
2016-06-15 19:41:31 +08:00 |
Lin Jen-Shin
|
1f5d55907a
|
Merge the places where exceptions could be raised
|
2016-05-24 01:23:07 +08:00 |
Lin Jen-Shin
|
863d8e5ae5
|
use split and try to unify error raising
|
2016-05-23 22:16:40 +08:00 |
Lin Jen-Shin
|
c64cd113cc
|
Add ! for verify_record! because it could raise
|
2016-05-21 09:46:27 -07:00 |
Lin Jen-Shin
|
75415663f8
|
Rename handlers and introduce Handler.for
|
2016-05-21 09:40:08 -07:00 |