Commit graph

11 commits

Author SHA1 Message Date
Pirate Praveen
c1b416e19f
remove peek performance_bar
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-04-26 09:03:30 +02:00
Sean McGivern
d77db0adbd Fix flash errors in performance bar for cached responses
When a request contains an ETag value in its If-None-Match header, the backend
may send a request ID (from Rack) that does not correspond to a value in Peek's
Redis cache (because we aborted the Rails processing in our ETag middleware).

Because a cached response (304) has to replace the headers with those from the
previous 200 - https://tools.ietf.org/html/rfc7234#section-4.3.4 - we add a
custom header that will only be present in cache hits, that can tell the
frontend to ignore these.
2018-04-17 11:50:27 +01:00
Filipa Lacerda
757da4dd33 Merge branch 'performance-bar-vue-resource' into 'master'
Add Vue resource interceptor to performance bar

See merge request gitlab-org/gitlab-ce!17915
2018-03-23 16:07:04 +00:00
Filipa Lacerda
3886489a47
Fix class name 2018-03-22 10:55:35 +00:00
Phil Hughes
58fe13ec9c Merge branch 'master' into '44453-performance-bar-modalbox'
# Conflicts:
#   app/assets/javascripts/performance_bar/components/detailed_metric.vue
2018-03-22 10:17:02 +00:00
Phil Hughes
27cd947489
fixed eslint 2018-03-21 17:42:24 +00:00
Phil Hughes
fc32b57384
Add Vue resource interceptor to performance bar 2018-03-21 17:16:25 +00:00
Phil Hughes
7d651ad1de
removed check for host
changed wrapper to container with correct widths
2018-03-21 16:49:57 +00:00
Phil Hughes
ab53f7aa13
Fix performance bar spacing 2018-03-21 16:28:07 +00:00
Filipa Lacerda
7224b8cea6
Adds a bigger width to the performance bar modal box and breaks the content 2018-03-20 17:26:30 +00:00
Sean McGivern
a200619d14 Show Ajax requests in performance bar
But first, rewrite the performance bar in Vue:

1. Remove the peek-host gem and replace it with existing code. This also allows
   us to include the host in the JSON response, rather than in the page HTML.
2. Leave the line profiler parts as here-be-dragons: nicer would be a separate
   endpoint for these, so we could use them on Ajax requests too.
3. The performance bar is too fiddly to rewrite right now, so apply the same
   logic to that.

Then, add features! All requests made through Axios are able to be tracked. To
keep a lid on memory usage, only the first two requests for a given URL are
tracked, though. Each request that's tracked has the same data as the initial
page load, with the exception of the performance bar and the line profiler, as
explained above.
2018-03-19 19:06:09 +00:00