Commit graph

24 commits

Author SHA1 Message Date
Robert Speicher
366ebe8b13 Fix failures introduced by Capybara upgrade 2017-09-05 10:12:12 -04:00
Robert Speicher
56ae036e41 Use empty_project where possible in spec/features/merge_requests 2017-07-27 13:12:17 -04:00
Keifer Furzland
7e113b6824 Remove superfluous type defs in specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:52 +02:00
Robert Speicher
9eeba8fb49 Auto-correct ProjectPathHelper violations 2017-07-06 12:20:50 -04:00
Robert Speicher
e939bf7be1 Change gitlab_sign_in to sign_in where possible 2017-06-29 12:18:23 -04:00
Robert Speicher
45fb1f9542 Change login_as uses to gitlab_sign_in 2017-06-19 18:59:01 -05:00
Annabel Dunstone Gray
c757000e83 Fix specs 2017-05-12 15:14:55 -05:00
Luke "Jared" Bennett
37a4f502be
Fix resolve spinner and add test 2017-04-11 17:41:57 +01:00
Douwe Maan
afa53810de
Fix specs 2017-04-05 17:44:14 +01:00
Eric Eastwood
cf3c43980d Fix link togglers jumping to top
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/29414
2017-03-28 11:09:12 -05:00
Nur Rony
2a7f4c48c5 resloves failed rspec test 2016-11-23 14:31:37 +06:00
Nur Rony
58f78d0571 makes system notes less intrusive to a conversation
adds dicussion icon and color change in system note links

adds discussion icons and sticky note icon for other system notes for now

fixes scss lint error

adds faded commit lists

hides first paragraph in commit list box

css tweak for commit list system notes

adds commit-list toggle functionality, css tweaks and css classnames more readable

small css fix in header. makes links bold in system note

renames class no-shade to hide-shade

adds entry for this merge request in changelog

removes commented line

removes the avatar-icon from discussion header

minor css tweaks to make the commit list alignment with header text

uses monospaced font to make the commit list lined up with all

removes icon from system note and align bullet list

resolves scss lint warings

adds helper function to extract system note message from first p tag

adds helper functions to check commit list count and haml cleanup

adds changelog entry under 8.14

adds changelog entry with changelog cli

removes helper and regex and makes commit list li count using JS

makes link in system note normal

brakeman build failure resolved

fixing rspec test based on new design for discussion

shows system note in lowercase

removes extra spaces from comments

adds code commenting for functions

adds semi-colon in some lines

fixes rspec given when merge build success

removes commented codes

rewrite changelog yml file

moves isMetaKey to common utils file

fixes some indentation issues

removes unnecessary variables and resolves some discussions

replaces jQuery parent function with siblings

fixes scss issues and variable spelling mistake

uses constant rather using hardcoded number for visible li count in long commit list

makes system note header all lowercase

uses color variables and adjust gradient a little

some minor changes for adding css classes

renames functions name for readability

changes changelog title

minor scss newline changes

makes system note less intrusive to a conversation
2016-11-17 14:41:08 +06:00
Phil Hughes
c095b04b9a Fixed tests for issue boards & diff note resolving 2016-11-10 17:53:34 +03:00
Nick Thomas
671556c611 Fix a failing spec in diff_notes_resolve_spec.rb 2016-10-28 00:51:30 +01:00
Connor Shea
4384222b38
Add test for jumping between discussions and unhiding toggled discussions. 2016-08-16 10:17:47 -06:00
Phil Hughes
c51cbc1f2f Updated issues with jump tp button
Fixed styling bugs
2016-08-01 10:06:31 +01:00
Phil Hughes
6656faedb0 Tests for not logged in user 2016-07-29 16:00:25 +01:00
Phil Hughes
03ea267f67 Added tests for hidden jump to button 2016-07-29 15:50:58 +01:00
Phil Hughes
d147894b84 Hides jump to next button if only one discussion visible 2016-07-29 15:22:26 +01:00
Phil Hughes
9878356dbc Added JS spec tests for CommentsStore
Updated other tests
2016-07-29 15:03:58 +01:00
Phil Hughes
6f94f62f72 Correctly cycles the unresolved discussions
Switches back to discussion tab when clicking jump to next unresolved button
2016-07-29 13:31:32 +01:00
Phil Hughes
4e679819f2 Fixed failing tests 2016-07-29 11:52:08 +01:00
Phil Hughes
2247d8a4fd Updates the text above discussions when resolving notes & discussions 2016-07-27 18:34:04 +01:00
Phil Hughes
86446846e9 Added tests for resolving comments feature 2016-07-27 16:57:48 +01:00