Commit graph

5 commits

Author SHA1 Message Date
Yorick Peterse
9aa705dd38
Turn reference regex constants into methods
`Mentionable::ReferenceRegexes` used to define the following two
constants:

1. DEFAULT_PATTERN
2. EXTERNAL_PATTERN

These two constants were built using some of the class methods that
reside in this same module. In EE we redefine one of these methods by
using `prepend` at the start of the `ReferenceRegexes` module. This
poses a problem: we can not move the `prepend` to the end of the file,
because the constants later on depend on it.

To resolve this problem, this commit turns these constants into class
methods that memoize their results. This allows EE to redefine the
appropriate methods before these two class methods are used, in turn
allowing us to move the `prepend` to the end of the file.

See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8198 for more
information.
2018-11-12 13:50:31 +01:00
Sean McGivern
9357585eca Remove EE-specific code from Mentionable 2018-09-17 19:36:53 +08:00
gfyoung
15b878e27e Enable more frozen string in app/models/**/*.rb
Partially addresses #47424.
2018-08-07 00:37:36 -07:00
Adam Niedzielski
9da3076944 Improve support for external issue references 2017-06-30 14:47:53 +02:00
James Edwards-Jones
020295fffc Use regex to skip unnecessary reference processing in ProcessCommitWorker 2017-05-04 20:03:46 +01:00