93a44e135b
Add some frozen string to spec/**/*.rb
...
Adds frozen string to the following:
* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb
xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
b44a2c801a
Update specs to rails5 format
...
Updates specs to use new rails5 format.
The old format:
`get :show, { some: params }, { some: headers }`
The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
a0930b83ec
Escapes milestone and label names when promoting them
2018-07-17 10:21:12 +01:00
a63bce1a4b
Resolve "Rename the `Master` role to `Maintainer`" Backend
2018-07-11 14:36:08 +00:00
27c95364b5
Replace '.team << [user, role]' with 'add_role(user)' in specs
2017-12-22 19:18:28 +11:00
2f40dac352
Refactor `have_http_status` into `have_gitlab_http_status` in the specs
2017-10-20 10:13:18 +02:00
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
fe13f11041
Create and use project path helpers that only need a project, no namespace
2017-07-05 11:11:59 -05:00
737d194c08
Allow group reporters to promote labels
...
They can admin group labels anyway, we weren't checking the more specific
permission.
2017-06-08 11:44:33 +01:00
49697bc8df
Refactor to more robust implementation
...
In order to avoid string manipulation or modify route params (to make them unambiguous for `url_for`), we are accepting a behavior change:
When being redirected to the canonical path for a group, if you requested a group show path starting with `/groups/…` then you’ll now be redirected to the group at root `/…`.
2017-05-19 09:13:27 -07:00
c6960ded8a
Refactor add_users method for project and group
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-04-21 18:38:10 +03:00
ad640bc5f9
Use Namespace#full_path instead of #path where appropriate
2017-02-23 17:55:01 -06:00
5d871dccbe
Abillity to promote project labels to group labels
...
Fixes #24021
2017-01-31 12:50:52 +01:00
9dfbe1d2a1
Add helper method to toggle label subscription on labels controller spec
2016-11-17 15:10:13 -02:00
4a29fde577
Allow users to subscribe to group labels at project-level
2016-11-17 15:10:13 -02:00
e2c603696a
Pass user instance to Labels::FindOrCreateService or skip_authorization: true
...
Do not pass project.owner because it may return a group and Labels::FindOrCreateService
throws an error in this case.
Fixes #23694 .
2016-10-28 11:31:45 +02:00
e696896487
Fix status code expectation
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-22 13:46:23 +02:00
0890aeb61a
Fix error in generating labels
...
Attempting to generate default set of labels would result in
an error:
ArgumentError: wrong number of arguments (given 1, expected 0)
Closes #23649
2016-10-22 02:16:21 -07:00
3c2aaec1f2
Fix sorting by label priorities
2016-10-19 14:58:27 -02:00
0bfa39d5bd
Remove scopes/types for labels
2016-10-19 14:58:25 -02:00
baf47a0bd0
Remove project_labels from Projects::ApplicationController
2016-10-19 14:58:24 -02:00
9e211091a8
Enable Style/EmptyLines cop, remove redundant ones
2016-07-01 21:56:17 +02:00
ee26c3cab4
Fix label order by priority on labels page
2016-06-07 14:01:30 +01:00
gfyoung