Bob Van Landuyt
|
79393a351d
|
Rebuild the dynamic path before validating it
Otherwise we won't validate updates to the path. Allowing users to
change the path to something that's not allowed.
|
2017-06-21 16:09:35 +02:00 |
|
Bob Van Landuyt
|
e564fe971f
|
Rename `Gitlab::Git::EncodingHelper` to `Gitlab::EncodingHelper`
|
2017-06-01 21:21:14 +00:00 |
|
Bob Van Landuyt
|
33aed43e9d
|
Avoid crash when trying to parse string with invalid UTF-8 sequence
|
2017-05-30 15:05:52 +00:00 |
|
Douwe Maan
|
43b1750892
|
Revert "Remove changes that are not absolutely necessary"
This reverts commit b0498c176f
|
2017-05-24 20:59:26 +00:00 |
|
Douwe Maan
|
b0498c176f
|
Remove changes that are not absolutely necessary
|
2017-05-23 20:38:35 -05:00 |
|
Douwe Maan
|
4345bb8c50
|
Fix ambiguous routing issues by teaching router about reserved words
|
2017-05-23 20:38:24 -05:00 |
|
Bob Van Landuyt
|
4b9eab02b8
|
Reject EE reserved namespace paths in CE as well
|
2017-05-04 18:11:31 +02:00 |
|
Bob Van Landuyt
|
49a8e5f510
|
Don't validate reserved words if the format doesn't match
Because it also won't match the sophisticated format we have for
detecting reserved names. We don't want to confuse the user with 2
error messages
|
2017-05-02 17:26:32 +02:00 |
|
Bob Van Landuyt
|
29f2001102
|
Update comments
|
2017-05-02 13:49:09 +02:00 |
|
Bob Van Landuyt
|
a035ebbe06
|
Update path validation & specs
|
2017-05-02 10:47:01 +02:00 |
|
Bob Van Landuyt
|
c853dd6158
|
Reuse Gitlab::Regex.full_namespace_regex in the DynamicPathValidator
|
2017-05-02 09:13:41 +02:00 |
|
Bob Van Landuyt
|
08b1bc3489
|
Reject group-routes as names of child namespaces
|
2017-05-01 11:14:24 +02:00 |
|
Bob Van Landuyt
|
1e14c3c852
|
Reject paths following namespace for paths including 2 `*`
Reject the part following `/*namespace_id/:project_id` for paths
containing 2 wildcard parameters
|
2017-05-01 11:14:24 +02:00 |
|
Bob Van Landuyt
|
2c7ca43bdd
|
Allow `graphs` & `refs` project names
|
2017-05-01 11:14:24 +02:00 |
|
Bob Van Landuyt
|
12735eefcd
|
Minor style adjustments
|
2017-05-01 11:14:24 +02:00 |
|
Bob Van Landuyt
|
ea8e86dac8
|
Use `%r{}` regexes to avoid having to escape `/`
|
2017-05-01 11:14:24 +02:00 |
|
Bob Van Landuyt
|
e50f4bc066
|
The dynamic path validator can block out partial paths
So we can block `objects` only when it is contained in `info/lfs` or `gitlab-lfs`
|
2017-05-01 11:14:24 +02:00 |
|
Bob Van Landuyt
|
c5059cb4f7
|
Make path validation case-insensitive
|
2017-05-01 11:14:24 +02:00 |
|
Bob Van Landuyt
|
9fb9414ec0
|
Reject `-` as a path
|
2017-05-01 11:14:24 +02:00 |
|
Bob Van Landuyt
|
bccf8d86c5
|
Rename `NamespaceValidator` to `DynamicPathValidator`
This reflects better that it validates paths instead of a namespace model
|
2017-05-01 11:14:24 +02:00 |