Commit graph

8 commits

Author SHA1 Message Date
Lin Jen-Shin
bb5f79d43e Don't include EmailHelpers manually, pick with rspec
`:mailer` is needed to pick it easily, while
`type: :mailer` is needed for picking it automatically for
tests located in spec/mailers/*_spec.rb

It's a bit complicated in spec/services/notification_service_spec.rb
but we'll leave it alone for now.
2017-08-03 21:55:48 +08:00
Sean McGivern
a1805cbcd5 Quiet pipeline emails
1. Never send a pipeline email to anyone other than the user who created
   the pipeline.
2. Only send pipeline success emails to people with the custom
   notification setting for enabled. Watchers and participants will
   never receive this.
3. When custom settings are unset (for new settings and legacy ones),
   act as if failed_pipeline is set.
2017-04-03 13:59:48 +01:00
Robert Speicher
68e6718932 Use :empty_project where possible in worker specs 2017-03-27 18:45:37 -04:00
Z.J. van de Weg
1096040024 Update effected tests 2016-12-04 17:32:33 +01:00
Robert Speicher
819f459b69 Only include EmailHelpers in mailer specs and specs using them 2016-12-01 12:17:33 +08:00
Lin Jen-Shin
6061c9fa3d Send only to users have :read_build access, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_17193335
2016-10-21 18:18:03 +08:00
Lin Jen-Shin
045c671533 Use bcc for pipeline emails because:
We use bcc here because we don't want to generate this emails for a
thousand times. This could be potentially expensive in a loop, and
recipients would contain all project watchers so it could be a lot.
2016-10-18 20:02:35 +08:00
Lin Jen-Shin
2e067480a9 Rename for a more consistent pipeline worker name, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342/diffs#note_17039533
2016-10-17 18:12:07 +08:00
Renamed from spec/workers/send_pipeline_notification_worker_spec.rb (Browse further)