Commit graph

8 commits

Author SHA1 Message Date
gfyoung
93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
Tiger
fc8c1a77d3 Validate session key when authorizing with GCP to create a cluster
It was previously possible to link a GCP account to another
user's GitLab account by having them visit the callback URL,
as there was no check that they were the initiator of the
request.

We now reject the callback unless the state parameter
matches the one added to the initiating user's session.
2019-02-19 17:21:08 +11:00
blackst0ne
b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Kamil Trzcinski
f9d490dbb9 Improve redirect uri state and fix all remaining tests 2017-10-06 16:14:14 +02:00
Shinya Maeda
cd438a6ae0 Use short path project_clusters_url 2017-10-06 21:37:50 +09:00
Shinya Maeda
f293288589 Security fix: redirection in google_api/authorizations_controller 2017-10-06 21:28:40 +09:00
Shinya Maeda
44baf2b0f4 spec/features/projects/clusters_spec. Fix static analysys 2017-10-05 23:58:05 +09:00
Shinya Maeda
fe135fac68 authorizations_controller_spec. cluster_policy_spec. 2017-10-05 21:29:22 +09:00