Commit Graph

2 Commits

Author SHA1 Message Date
Yorick Peterse c8997ae5d2
Remove invalid broadcast messages before migrating
This prevents the migration from failing to set "NOT NULL" constraints
when some rows contain NULL values that are no longer allowed.
2017-08-14 17:05:32 +02:00
Yorick Peterse a5c8a52782
Better caching and indexing of broadcast messages
Caching of BroadcastMessage instances has been changed so a cache stays
valid as long as the default cache expiration time permits, instead of
the cache being expired after 1 minute. When modifying broadcast
messages the cache is flushed automatically.

To remove the need for performing sequence scans on the
"broadcast_messages" table we also add an index on (starts_at, ends_at,
id), permitting PostgreSQL to use an index scan to get all necessary
data.

Finally this commit adds a few NOT NULL constraints to the table to
match the Rails validations.

Fixes gitlab-org/gitlab-ce#31706
2017-08-11 16:43:30 +02:00