Commit graph

25 commits

Author SHA1 Message Date
Connor Shea
b1c9475443
Replace reject_blocked with reject_blocked! in callbacks.
In Rails 4.2 and below, skipping callbacks (skip_before_action, skip_after_action, etc.) that use methods which do not exist will not throw any errors.

On the other hand, Rails 5 does. See https://github.com/rails/rails/pull/19029

After testing with Rails 5 I noticed there are some methods that don't actually exist (because they were renamed, usually), this fixes a few instances of those.

reject_blocked! was introduced in c9def945d4, I can't find any references to reject_blocked ever existing.
2016-07-27 13:56:30 -06:00
Rémy Coutable
6b7e9c7655
Remove VideoJS and clean the integration
Handle videos in:
- MD preview in notes: commit, issue/MR, MR diff
- New notes in: commit, issue/MR, MR diff
- Persisted notes in: commit, issue/MR, MR diff

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-07-20 11:36:42 +02:00
Connor Shea
bd09b2d563
Clean path info 2016-07-11 13:12:55 -06:00
Connor Shea
3358afa758
Update the help_page_path route to accept paths directly instead of using parameters. 2016-07-11 12:55:25 -06:00
Jacob Schatz
e79b0dd762 Simplify random user generation. 2016-04-16 16:00:30 -04:00
Jacob Schatz
ffd2416c56 Make a user available for the user variable 2016-04-16 09:28:04 -04:00
Robert Speicher
95f73a68fa Simplify help path prefixing 2015-09-23 00:24:17 -04:00
Robert Speicher
64e0dfa530 Prevent double-prefixing of help page paths
Prior, because the link "api/README.md" was matched twice, the first
link became "help/help/api/README.md". Now we do a negative lookahead to
make sure the link doesn't start with `help/`.

This fix is still not ideal, see TODO note.
2015-09-22 18:26:51 -04:00
Douwe Maan
c258e97747 Make Help accessible for guests. 2015-09-08 14:42:30 +01:00
Robert Speicher
a42c548a8d Use File.join instead of Rails.root.join in HelpController 2015-08-18 09:08:03 -07:00
Douwe Maan
92fd3ccee0 Add helpers for header title and sidebar, and move setting those from controllers to layouts. 2015-05-01 10:39:16 +02:00
Douwe Maan
8c4b6d426d Set head panel title of help section. 2015-04-30 21:28:07 +02:00
Douwe Maan
26ad250989 Add a page title to every page. 2015-04-30 19:12:15 +02:00
Robert Speicher
2d4ffce826 Loosen help page parameter constraints for category 2015-04-15 13:15:18 -04:00
Robert Speicher
3052e89420 Re-fix image rendering for help pages 2015-04-15 12:45:31 -04:00
Robert Speicher
ef47ea3d39 Revert "Fix and improve help rendering"
This reverts commit d365004e68.
2015-04-15 12:24:44 -04:00
Douwe Maan
5e2f25c32e Add explanation to HelpController#clean_path_info. 2015-04-14 13:07:15 +02:00
Douwe Maan
edd05fc48c Fix directory traversal vulnerability around help pages. 2015-04-10 18:18:37 +02:00
Sullivan SENECHAL
d365004e68 Fix and improve help rendering 2015-04-03 11:56:50 +02:00
Dmitriy Zaporozhets
b5c3e1a431 Add GitLab UI development kit 2015-03-08 14:46:22 -07:00
Dmitriy Zaporozhets
6a7990c007
Remove garbage and apply wiki style
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-06-14 15:51:07 +03:00
Job van der Voort
fd476cf620 render items from doc 2014-05-29 08:44:25 +02:00
Dmitriy Zaporozhets
6e550af150 Show shotcut dialog on ? 2013-06-30 22:10:52 +03:00
Dmitriy Zaporozhets
68d146b4a6 Improve api docs 2013-06-06 13:19:23 +03:00
Dmitriy Zaporozhets
15c4655527 UI: add new button, top panel restyle etc 2012-01-18 22:15:45 +02:00