Commit graph

11 commits

Author SHA1 Message Date
Luke "Jared" Bennett
bc31040ea9
Fixed lint warning and propose fail or warning 2016-12-10 12:04:54 +00:00
Luke "Jared" Bennett
c145413d1a
Remove JSX/React eslint plugins.
Change airbnb eslint config package to `eslint-config-airbnb-base` and update plugins.

Change `airbnb` to `airbnb-base` for .eslintrc `extends` value.

Added changelog entry

Made sure all plugins and envs are set

Corrected new failing specs
2016-11-29 16:15:47 +00:00
Robert Speicher
0676c5c714 Merge branch 'eslint-html-report' into 'master'
Generate ESLint HTML report

## What does this MR do?

Generate a HTML report for the linting errors that ESLint discovered
(including files that contain `/* eslint-disable */`).

See merge request !7374
2016-11-23 07:09:05 +00:00
Fatih Acet
7b252e878f Merge branch '24754-fix-npm-warnings-for-eslint-plugin-import' into 'master'
Fix NPM install warnings due to incompatible dependency version

## What does this MR do?

Rolls back `eslint-plugin-import` to semver `^1.16.0` for compatibility with `eslint-config-airbnb`.

## Are there points in the code the reviewer needs to double check?

Shouldn't be.

## Why was this MR needed?

A warning message was being generated every time we run `npm install`, and there are possibly other side effects due to module incompatibility.

## Does this MR meet the acceptance criteria?

- [x] All builds are passing
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)

## What are the relevant issue numbers?

Closes #24754

See merge request !7641
2016-11-22 19:58:46 +00:00
winniehell
459cd939e7 Generate ESLint HTML report (!7374) 2016-11-22 20:25:33 +01:00
Mike Greiling
855567ac58 roll back eslint-plugin-import node module to the version required by eslint-config-airbnb 2016-11-21 17:05:43 -06:00
Luke "Jared" Bennett
aed42cc099
Add node_modules cache to npm related builds 2016-11-19 01:47:59 +00:00
Luke "Jared" Bennett
4f377364ad
Added new .eslintrc for jasmine tests and corrected build_spec 2016-11-04 15:25:22 +00:00
winniehell
1ad62d9684 Check that JavaScript file names match convention (!7238) 2016-11-02 11:47:38 +01:00
winniehell
4060807719 Enable linting for ES6 files 2016-10-27 21:35:07 +02:00
winniehell
e5a0d41db0 add ESLint
ESLint config: https://github.com/airbnb/javascript
2016-10-26 10:00:55 +02:00