Commit graph

11 commits

Author SHA1 Message Date
Grzegorz Bizon
9bd860bef2 Optimize notification emails specs 2017-09-01 12:34:20 +02:00
Lin Jen-Shin
bb5f79d43e Don't include EmailHelpers manually, pick with rspec
`:mailer` is needed to pick it easily, while
`type: :mailer` is needed for picking it automatically for
tests located in spec/mailers/*_spec.rb

It's a bit complicated in spec/services/notification_service_spec.rb
but we'll leave it alone for now.
2017-08-03 21:55:48 +08:00
Robert Speicher
72a7b30c9f Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
Gabriel Mazetto
abb878326c Rename many path_with_namespace -> full_path 2017-08-01 07:26:58 +02:00
Robert Speicher
8ec8aa1471 Use :empty_project where possible in mailer specs 2017-03-27 18:45:36 -04:00
Robert Speicher
fe390a8b8c Miscellaneous cleanup of Notify shared examples 2017-03-21 18:20:53 -04:00
Robert Speicher
6fb81afe98 Remove the 'custom subject suffix' spec from a shared example
This one-off test case is covered in the Notify mailer spec, so there
was no benefit in testing it every time this shared example was
referenced.
2017-03-21 16:10:03 -04:00
Robert Speicher
4abca08f14 Move the a new user email shared example to the Emails::Profile spec
This shared example was only used by this spec so having it in a
separate file provided no benefit, at the cost of clarity. This also
reduces the three `it` blocks into a single test with
`aggregate_failures`.
2017-03-21 16:07:52 -04:00
Pawel Chojnacki
c3a940000e Handles unsubscribe from notifications via email
- allows unsubscription processing of email in format "reply+%{key}+unsubscribe@acme.com" (example)
- if config.address includes %{key} and replies are enabled every unsubscriable message will include mailto: link in its List-Unsubscribe header
2017-01-13 10:11:46 -05:00
Lin Jen-Shin
e90a555745 Merge remote-tracking branch 'upstream/master' into pipeline-notifications
* upstream/master: (73 commits)
  Stop unauthized users dragging on issue boards
  Capitalize Git
  Add docker-compose environment initialization command
  Improve readability and add specs for label filtering
  Improve label filtering implementation
  Allow the use of params[:name] when filtering labels
  Fix Rubocop offenses in issue move specs
  Add spec in Issues::MoveService to fix label assignment regression
  Fix bug where labels would be assigned to issues that were moved
  Fix `User#to_reference`
  Fix rubocop build error
  Remove redundant class_name and foreign_key overrides
  Enable SingleLinePerSelector in scss-lint
  Escape ref and path for relative links (!6050)
  Add failing test for #21420
  Enable SpaceAfterVariableColon in scss-lint
  Enable SpaceAroundOperator in scss-lint
  Enable trailingWhitespace in scss-lint
  Disable Rails/Output cop since it makes no sense here
  Use File.write instead of File.open + File#write
  ...
2016-10-25 23:03:47 +08:00
Jared Ready
204da00ea0 Move spec/mailers/shared/notify.rb to spec/support 2016-10-22 17:51:50 -05:00
Renamed from spec/mailers/shared/notify.rb (Browse further)