Commit Graph

17 Commits

Author SHA1 Message Date
GitLab Bot 874ead9c3a Add latest changes from gitlab-org/gitlab@master 2020-04-14 15:09:44 +00:00
Thong Kuah 85b29c1c2f Add frozen_string_literal to spec/services
Probably useful as we often move these files to "new" files.
2019-04-12 10:14:54 +12:00
Thong Kuah 88800abcd8 Abstract out project out of ClustersController
To the extent possible swap out `project` with `clusterable`

- Abstract paths for showing cluster or clusters. This will allow us to
swap in alternative paths for group level cluster

- Push :project_id and :namespace_id params from the URL to the POST
body.

- Create a nice helper for to generate links for the destroy
action

For some reason, spec :project_id and :namespace_id param are not going
through `to_param` for a JSON format. Manually call `to_param` to fix
specs.

- Move :layout to BaseController
2018-11-01 19:36:58 +13:00
Thong Kuah 305ab0405a Revert "Merge branch 'refactor-cluster-create-service-spec' into 'master'"
This reverts merge request !22407
2018-10-22 20:12:26 +00:00
Thong Kuah c3c22cb210 Move shared examples into the only file where used
This will make it easier to perform in place adjustments, etc for future
MRs involving group clusters.
2018-10-17 10:43:14 +13:00
Thong Kuah 19e1024bb8 Pass in project as kwarg for CreateService
This enables us to have other options in the future such as passing in
`group:`.

Also, remove project arg from UpdateService, as un-used.

This will help group cluster controller to re-use this services.
2018-10-15 11:01:09 +13:00
Matija Čupić f96552c7c7
Extract shared components from Clusters::CreateService spec 2018-05-13 14:17:34 +02:00
Mayra Cabrera ca59bfdc66 Rearrange DeploymentPlatform methods
- Change find_cluster_platform_kubernetes to ignore environment argument
- Fix broken specs

CE Port of: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5047/
2018-03-22 14:52:33 -06:00
Matija Čupić 0ef16b2720
Remove redundant empty line in CreateService spec 2017-12-06 00:54:26 +01:00
Matija Čupić dbb8644c24
Refactor Clusters::CreateService spec 2017-12-06 00:09:03 +01:00
Matija Čupić 363c57468d
Raise error when trying to create second cluster 2017-12-03 17:33:38 +01:00
Matija Čupić afcfe182a6
Check behaviour when adding more than one cluster 2017-11-18 21:04:20 +01:00
Shinya Maeda a99ad59e65 Remove 10.3 comments (Tracked by a tech debts issue). Refactor spec factory name. Use ArgumentError 2017-11-06 23:06:10 +09:00
Shinya Maeda 3602c0b987 Fix some tests 2017-11-03 03:37:32 +09:00
Shinya Maeda 6571efb6c3 Fix spec. Fix usage ping. Fix warnings by adding new models and attributes. 2017-11-01 16:12:44 +09:00
Shinya Maeda 253bf69dda specs for feature 2017-11-01 03:59:40 +09:00
Shinya Maeda d6744d9838 specs for services. Improved details. 2017-10-30 21:55:18 +09:00