Commit graph

19 commits

Author SHA1 Message Date
Nikolay Novikov
5f1038c888 Skip TeamCity on branch delete and add MR trigger
This is a take over from a community contribution:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20990

Skip TeamCity push event when related to branch delete

Support merge request events for TeamCity service.
Add checkbox for merge request triggers in the TeamCity
configuration page.
2019-06-21 15:17:47 +01:00
Douwe Maan
a9bcddee4c Protect Gitlab::HTTP against DNS rebinding attack
Gitlab::HTTP now resolves the hostname only once, verifies the IP is not
blocked, and then uses the same IP to perform the actual request, while
passing the original hostname in the `Host` header and SSL SNI field.
2019-05-30 10:47:31 -03:00
Thong Kuah
a2cfc150ce Add # frozen_string_literal to spec/models
Adds `# frozen_string_literal: true` to spec/models ruby files
2019-04-01 14:37:54 +13:00
Willi Nesensohn
df73b90a43 Use revision instead of build number for TC query. 2019-01-10 16:34:49 +00:00
Robert Speicher
72a7b30c9f Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
Rémy Coutable
ddccd24c13 Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Paul Charlton
cb3b4a15e6 Support multiple Redis instances based on queue type 2017-07-11 03:35:47 +00:00
http://jneen.net/
2f0a7088d3 rm use of deprecated webmock api in teamcity_service_spec 2017-06-26 18:00:01 -07:00
Robert Speicher
a6ec5121f0 Correct RSpec/SingleLineHook cop offenses 2017-06-14 13:18:56 -05:00
Douwe Maan
bdbc7d967a Revert "Enable Style/BarePercentLiterals"
This reverts commit 96bef54154e669f9a3e92c3a4bc76c0be3a52e48.
2017-02-23 09:32:42 -06:00
Douwe Maan
baafd8de26 Enable Style/BarePercentLiterals 2017-02-23 09:31:57 -06:00
Robert Speicher
e75b1f1105 Merge branch '24185-legacy-ci-status-reactive-cache' into 'security'
Use ReactiveCaching to update external CI status asynchronously

See https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2055
2017-01-12 17:39:46 -05:00
Valery Sizov
8b2dbe8997 Remove schema annotations completely 2016-09-16 14:37:48 +03:00
Rémy Coutable
2f7b2057f2 Fix broken URI joining for teamcity_url with suffixes
If one had configured a `teamcity_url` like http://foo.bar/teamcity in
the previous implementation the plugin directed it's request i.e. to
http://foo.bar/httpAuth/... instead of http://foo.bar/teamcity/httpAuth/...

`URI.join` only works correctly, if the prefix URL has
  - at least one or more  trailing '/'
  - the appended parts are _not_ prefixed with '/'

The current implementation should work with all sorts of TeamCity base
URLs.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-14 10:07:37 +02:00
Paco Guzman
be98ee2586
Fixing specs stubbed objects cannot access database 2016-06-10 15:41:56 +02:00
Rémy Coutable
ef340f6e77 Ensure URL in all Service subclasses are valid
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-04-25 15:28:24 -04:00
Rémy Coutable
3ea955a637
Improve TeamcityService and its specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-04-13 10:01:49 +02:00
Alex Lossent
98e666ab6a Improve invalidation of stored service password if the endpoint URL is changed
Password can now be specified at the same time as the new URL, and the service
template admin pages now work.
2015-10-15 12:07:59 +02:00
Valery Sizov
07f6055272 Invalidate stored service password if the endpoint URL is changed 2015-10-12 13:21:57 +03:00