Commit graph

19 commits

Author SHA1 Message Date
Robert Speicher
17c8d15b14 Enable Lint/EmptyWhen cop and correct offense 2017-02-13 11:00:20 -05:00
Robert Speicher
5db56efe42 Enable Style/RedundantException cop and correct offense 2017-02-10 17:40:38 -05:00
Robert Speicher
92cbc1e4ad Enable the RSpec/ExpectActual cop and correct offenses 2017-02-10 17:40:38 -05:00
Robert Speicher
cb8d031e95 Explicitly disable the RSpec/BeEql cop
This is a little too picky, even for us.
2017-02-10 16:44:13 -05:00
Sean McGivern
476fce4e18 Disable all cops in .rubocop_todo.yml
Cops with a max level are auto-generated with that set to the current
maximum, even when they're supposed to be ignored. For now, the best
option is to manually disable them.
2017-01-17 12:25:32 +00:00
Grzegorz Bizon
8a75f68dde Fix Rubocop YAML config files to avoid CE->EE issues 2017-01-11 10:48:29 +01:00
Brian Neel
23316b4963 Update rubocop and rubocop-rspec to fix build errors 2017-01-06 13:52:18 -05:00
Robert Speicher
961c53c2ca Update RuboCop to 0.43.0 and update configuration
`Style/VariableNumber` is explicitly disabled because I don't think we
care if we name a variable `var_1` or `var1`.
2016-10-04 13:28:01 +02:00
Robert Speicher
4a191c83d1 Enable Lint/StringConversionInInterpolation cop and autocorrect offenses 2016-10-03 16:09:57 +02:00
Robert Speicher
287293bec1 Regenerate .rubocop_todo.yml based on rubocop 0.42.0 2016-09-14 15:50:11 -04:00
Gabriel Mazetto
c9aa19881c Enable Style/SpaceAroundEqualsInParameterDefault cop 2016-08-06 04:03:01 +02:00
Robert Speicher
34c083a184 Merge branch 'rubocop/enable-access-modifiers-cops' into 'master'
Enable Rubocop cops that check access modifiers

## What does this MR do?

This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.

This also fixes existing offenses.

## Why was this MR needed?

Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.

## What are the relevant issue numbers?

See #17478  
Closes #17372 

See merge request !5014
2016-07-29 15:58:09 +00:00
Grzegorz Bizon
07be594378 Enable Style/MultilineTernaryOperator rubocop cop
Avoid multi-line ?: (the ternary operator). Use if/unless instead.

See #17478
2016-07-20 14:24:39 +02:00
Grzegorz Bizon
d6f6697744 Enable Rubocop cops for invalid access modifiers
This enables following cops:

Check for useless access modifiers

  Lint/UselessAccessModifier

Checks for attempts to use `private` or `protected` to set the
visibility of a class method, which does not work.

  Lint/IneffectiveAccessModifier

This also disables two false possitives in concerns.
2016-07-19 15:12:15 +02:00
Connor Shea
82c500a2b6
Disable all cops with offenses. 2016-07-13 12:39:14 -06:00
Connor Shea
9468b07925
Resolve feedback. 2016-07-13 12:12:47 -06:00
Connor Shea
c4cbf3effa
Disable two cops as recommended. 2016-07-13 12:12:47 -06:00
Connor Shea
fb4f3a473b
Remove some disabled cops. 2016-07-13 12:12:47 -06:00
Z.J. van de Weg
ae6edf18fc
Update rubocop to 0.41.2
https://github.com/bbatsov/rubocop/blob/v0.41.2/CHANGELOG.md
2016-07-13 12:12:47 -06:00