Commit graph

24 commits

Author SHA1 Message Date
Luke "Jared" Bennett
7cefaea876
explicitly disable eslint inline 2016-11-15 16:30:34 +00:00
Valery Sizov
b7dff1b072 Fix: Todos Filter Shows All Users 2016-11-04 13:41:14 +02:00
Fatih Acet
dd5e46ab69 Merge branch 'eslint' into 'master'
Add ESLint

## What does this MR do?

- create `package.json`
- add ESLint dependencies to `package.json`
- add JavaScript linting to CI
- add Rake task `lint:javascript`as alias for `eslint` (which itself is an alias for `npm run eslint`)

## Are there points in the code the reviewer needs to double check?

Probably not.

## Why was this MR needed?

My hovercraft was full of eels.

## What are the relevant issue numbers?

- https://gitlab.com/gitlab-org/gitlab-ce/issues/13224#note_12537431
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5006#note_13255658


See merge request !5445
2016-10-26 16:31:08 +00:00
winniehell
02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Phil Hughes
29645f06e7 Hides/shows the boards sidebar
Rather than constructing & then deconstructing, we know just hide & show
the sidebar. This is done so we dont' have a memory leak on the frontend
with objects getting created.
2016-10-20 08:54:33 +01:00
Phil Hughes
f1350a5c82 Merge branch 'master' into issue-board-sidebar 2016-10-19 08:44:55 +01:00
Dmitriy Zaporozhets
c736ffdfb0
Validate user id for users select autcomplete
Single user autcomplete should be used only for existing users with
digital ID provided. Now js code puts any input into generating user URL
which can lead to 500 error because routing like this does not exists:

GET "/autocomplete/users/whatever@example.com.json".

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-14 16:04:23 +03:00
Sean McGivern
11e93ad59d Merge branch 'feature/issues-board' into 'master'
Refactoring Issues Board

## What does this MR do?

This MR aims to minimize conflicts between the CE issues board feature with EE multiple boards feature.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

To avoid a lot of conflicts with EE multiple boards feature.

## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [ ] ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [x] API support added
- Tests
  - [X] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [X] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/929

https://gitlab.com/gitlab-org/gitlab-ee/issues/1084

See merge request !6727
2016-10-13 14:21:14 +00:00
Phil Hughes
25c82c6faf Updated JS to work with issue index & show 2016-10-12 17:43:20 +01:00
Mitchell Hentges
f19766a3c2 Ensure that whitespace doesn't case adding members to fail 2016-10-10 18:26:22 -07:00
Phil Hughes
18607d6c88 Added tests 2016-10-07 09:15:46 +01:00
Phil Hughes
e6fa8a3d10 Fixed sidebar dropdowns to work with Vue 2016-10-07 09:15:46 +01:00
Phil Hughes
6b3e3aeb9e Sidebar details update when changing
Need to get working the subscription
Styling updates
2016-10-07 09:14:55 +01:00
Dmitriy Zaporozhets
6b90ccb9fd Change user & group landing page routing from /u/:name & /groups/:name to /:name
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-10-06 19:50:48 +03:00
Fatih Acet
1956bd5e9e Add position menu above ability to glDropdown. 2016-10-04 23:47:55 +03:00
Phil Hughes
cc88fa4d5b Merge branch 'master' into revert-c676283b 2016-10-03 09:10:20 +01:00
Jared Deckard
7f6474b269 Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
Phil Hughes
7418873b41 Merge branch 'master' into revert-c676283b 2016-08-30 11:21:29 +01:00
Phil Hughes
aa05b5ed8b Moved board store to namespaced gl object 2016-08-17 17:17:39 +01:00
Phil Hughes
69458c0e4a Keeps the filters after a reload 2016-08-17 17:12:47 +01:00
Phil Hughes
fce8ee3e54 Can filter by author & assignee 2016-08-17 17:12:47 +01:00
Rik de Groot
d3deba04f9 fix: respect data-attribute 'skip-users' in user_selects
* Respect parameters of each individual select,
  instead of the global.
* Update skipped users in approver search when removed from default approvers.
2016-08-05 16:49:11 +01:00
Sean McGivern
dc4de2d8e2 Allow skipping users in autocomplete
Pass an array of user IDs in the `skip_users` param to have them
excluded from the results (unless they are explicitly included through
the `current_user` or `author_id` params).
2016-07-27 14:10:49 +01:00
Fatih Acet
aaa9509d12 ES6ify all the things! 2016-07-24 23:45:11 +03:00