Commit graph

20 commits

Author SHA1 Message Date
Sean McGivern
acf49c6d89 Fix access to the final page of todos
The todos page limit is 20, and both that and a user's pending todo count are
integers. Using integer division means that the result's floor will be taken,
defeating the point of the later call to `#ceil`.

So we need to convert one side of the division to a float first, otherwise the
last page won't be treated as available.
2017-11-09 13:13:48 +00:00
Jacopo
2f40dac352 Refactor have_http_status into have_gitlab_http_status in the specs 2017-10-20 10:13:18 +02:00
Bob Van Landuyt
741fb49378 Merge branch 'master' into bvl-group-trees 2017-10-10 17:53:42 +02:00
Bob Van Landuyt
3a4dc55f29 Reuse the groups tree for explore and dashboard. 2017-10-04 22:49:41 +02:00
Bob Van Landuyt
3e6dd7d88d Use same response-body in groups-dashboard as we do for group-home 2017-10-04 22:49:41 +02:00
Sean McGivern
063b9edc77 Save a query on the todos index page
When there are no filters, we can get the total todos count from the cached
count on the user object, instead of performing a DB query. This query takes
about 80ms for me on GitLab.com.
2017-10-04 17:37:38 +01:00
Robert Speicher
72a7b30c9f Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
Sean McGivern
ceda6bd5a6 Merge branch '33303-404-for-unauthorized-project' into 'security-9-3'
[9.3 security fix] Renders 404 if given project is not readable by the user on Todos dashboard

See merge request !2118
2017-07-19 22:28:34 -05:00
Nick Thomas
6b4da27e97 Fix dashboard labels dropdown 2017-07-07 14:35:16 +01:00
Phil Hughes
c0c82368da Fixed dashboard milestone tabs not loading
Closes #33477
2017-06-09 09:57:42 +01:00
Valery Sizov
387c4b2c21 Backport of multiple_assignees_feature [ci skip] 2017-05-04 17:11:53 +03:00
Jacopo
ff76adb547 Unnecessary "include WaitForAjax" and "include ApiHelpers"
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
Sean McGivern
b80653bb6a Merge branch 'open-redirect-host-fix' into 'security'
Fix for three open redirect vulns using redirect_to url_for(params.merge)))

See merge request !2082
2017-04-05 21:06:58 -07:00
Jacopo
5f9ace8eb1 Add 'Undo mark all as done' to Todos
Added the ability to 'Undo mark all as done' todos marked as complete with 'Mark all as done'
in the 'Todo' tab of the Todo dashboard.
The operation undos only the todo previously marked as done with the 'Mark al as done' button.
2017-03-16 07:15:00 +01:00
Nur Rony
6f5b3dc7a0
fix rspec issue after delimiter fix 2017-02-22 14:44:01 +06:00
Jacopo
26160459b5 Todo done clicking is kind of unusable.
The Done button will change to an Undo button and the line item will be greyed out.
Bold links will be unbolded.
The user can undo the task by clicking the Undo button.
2017-02-17 22:12:19 +01:00
Robert Speicher
4642ca6686 Use empty_project where possible in controller specs 2017-01-25 17:14:38 -05:00
Tiago Botelho
bf4a042f6a fixes the issue 2017-01-12 15:49:48 -05:00
Tiago Botelho
d7a2e92ca0 applies url_for so that we dont lose filters when redirecting 2016-12-23 15:09:34 +00:00
Tiago Botelho
805bbe8893 adds specs for respective behaviour 2016-12-21 23:53:24 +00:00