Commit graph

13 commits

Author SHA1 Message Date
Rémy Coutable
3db37e0562 Enable the Style/TrailingCommaInArguments cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
mhasbini
0a09925dce Enable Style/Proc cop for rubocop 2017-04-02 12:48:43 +03:00
Drew Blessing
de4eee0894 LDAP attributes needs default values 2017-01-06 00:24:33 -06:00
Drew Blessing
c50b98da72 Centralize LDAP config/filter logic
Centralize all LDAP config logic in `GitLab::LDAP::Config`. Previously,
some logic was in the Devise initializer and it was not honoring the
`user_filter`. If a user outside the configured `user_filter` signed
in, an account would be created but they would then be denied access.
Now that logic is centralized, the filter is honored and users outside
the filter are never created.
2016-11-11 15:58:33 -06:00
Drew Blessing
dc30783057 Introduce better credential and error checking to rake gitlab:ldap:check
It was previously possible for invalid credential errors to go unnoticed
in this task. Users would believe everything was configured correctly and
then sign in would fail with 'invalid credentials'. This adds a specific
bind check, plus catches errors connecting to the server. Also, specs :)
2016-11-08 15:46:10 -06:00
Grzegorz Bizon
e052daa08a Enable Style/EmptyLinesAroundAccessModifier rubocop cop
See #17478
2016-06-03 10:34:20 +02:00
Drew Blessing
67aa0b8c4c Optimize LDAP and add a search timeout 2016-01-11 08:17:32 -06:00
Douwe Maan
0e9ba0a4fa Add attributes to LDAP::Config. 2015-09-08 17:34:18 +01:00
Douwe Maan
238e4f0295 Add config var to block auto-created LDAP users. 2015-04-14 17:09:05 +02:00
Jacob Vosmaer
325b66365b Remove special cases for the 'ldap' provider 2015-04-13 11:04:31 +02:00
Jacob Vosmaer
472a6621e9 Fix LDAP config lookup for provider 'ldap' 2014-10-23 22:57:16 +02:00
Jan-Willem van der Meer
6ce65a3e95 Use Hash syntax for LDAP server declaration 2014-10-14 13:13:59 +02:00
Jan-Willem van der Meer
01b791237c Refactor lib files for multiple LDAP groups 2014-10-13 17:24:05 +02:00