Commit graph

21 commits

Author SHA1 Message Date
Rémy Coutable
c946ee1282
Enable the Layout/SpaceBeforeBlockBraces cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-09 11:52:22 +02:00
Rémy Coutable
cddc5cacfb Use described_class when possible
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Rémy Coutable
ddccd24c13 Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Michael Kozono
7f92a36a36 Fix plain LDAP (no encryption) 2017-07-26 02:43:40 -07:00
Michael Kozono
72d8b1e40a Move backwards compatibility logic out of the code
And closer to the configuration setup. The code doesn’t need to know about this.
2017-07-26 02:43:36 -07:00
Michael Kozono
2d7d1fa69d Pass configured ssl_version to omniauth-ldap 2017-07-26 02:43:36 -07:00
Michael Kozono
c8dd77de81 Pass configured ca_file to omniauth-ldap 2017-07-26 02:43:35 -07:00
Michael Kozono
cd13e4ae73 Verify certificates in omniauth-ldap 2017-07-26 02:43:35 -07:00
Michael Kozono
612b386450 Set Net::LDAP ssl_version option 2017-07-26 02:43:34 -07:00
Michael Kozono
dcc12505aa Set Net::LDAP ca_file option 2017-07-26 02:43:34 -07:00
Michael Kozono
b67c007842 Set Net::LDAP encryption properly 2017-07-26 02:43:33 -07:00
Michael Kozono
94b4c9f34f Use encryption instead of method
The method key is deprecated in the `gitlab_omniauth-ldap` gem.
2017-07-26 02:43:33 -07:00
Drew Blessing
de4eee0894 LDAP attributes needs default values 2017-01-06 00:24:33 -06:00
Drew Blessing
c50b98da72 Centralize LDAP config/filter logic
Centralize all LDAP config logic in `GitLab::LDAP::Config`. Previously,
some logic was in the Devise initializer and it was not honoring the
`user_filter`. If a user outside the configured `user_filter` signed
in, an account would be created but they would then be denied access.
Now that logic is centralized, the filter is honored and users outside
the filter are never created.
2016-11-11 15:58:33 -06:00
Drew Blessing
dc30783057 Introduce better credential and error checking to rake gitlab:ldap:check
It was previously possible for invalid credential errors to go unnoticed
in this task. Users would believe everything was configured correctly and
then sign in would fail with 'invalid credentials'. This adds a specific
bind check, plus catches errors connecting to the server. Also, specs :)
2016-11-08 15:46:10 -06:00
Douwe Maan
13d6bab177 Tag lib specs 2015-12-09 11:55:42 +01:00
Robert Speicher
0f627f1c60 Fix raise_error without an argument deprecation warnings 2015-06-22 12:13:47 +02:00
Jacob Vosmaer
65a3928b0b Remove test for 'ldap' provider special case 2015-04-13 12:58:10 +02:00
Jeroen van Baarsen
0c4a70a306 Updated rspec to rspec 3.x syntax
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-02-12 19:17:35 +01:00
Jacob Vosmaer
472a6621e9 Fix LDAP config lookup for provider 'ldap' 2014-10-23 22:57:16 +02:00
Jan-Willem van der Meer
23b692c701 Add specs for authentication and config 2014-10-14 09:31:38 +02:00