Commit graph

21 commits

Author SHA1 Message Date
Tiago Botelho
4b6e583ce0 adds test suite 2017-01-22 00:02:29 +00:00
Tiago Botelho
cd51af1a99 adds events to services api deserialization 2017-01-22 00:02:29 +00:00
Robert Speicher
e75b1f1105 Merge branch '24185-legacy-ci-status-reactive-cache' into 'security'
Use ReactiveCaching to update external CI status asynchronously

See https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2055
2017-01-12 17:39:46 -05:00
Jeroen van Baarsen
f1479b56b7
Remove the annotate gem and delete old annotations
In 8278b763d9 the default behaviour of annotation
has changes, which was causing a lot of noise in diffs. We decided in #17382
that it is better to get rid of the whole annotate gem, and instead let people
look at schema.rb for the columns in a table.

Fixes: #17382
2016-05-09 18:00:28 +02:00
Zeger-Jan van de Weg
47da013cf8 Annotate the models 2016-05-06 08:27:46 +02:00
James Lopez
fc610c182e add SHA256 to secure_compare 2016-03-08 15:57:45 +01:00
James Lopez
70623cd423 fix token issue - timing attack 2016-03-02 12:18:43 +01:00
Yorick Peterse
b4ee6f57b9 Greatly improve external_issue_tracker performance
This greatly improves the performance of Project#external_issue_tracker
by moving most of the fields queried in Ruby to the database and letting
the database handle all logic. Prior to this change the process of
finding an external issue tracker was along the lines of the following:

1. Load all project services into memory.
2. Reduce the list to only services where "issue_tracker?" returns true
3. Reduce the list from step 2 to service where "default?" returns false
4. Find the first service where "activated?" returns true

This has to two big problems:

1. Loading all services into memory only to reduce the list down to a
   single item later on is a waste of memory (and slow timing wise).
2. Calling Array#select followed by Array#reject followed by Array#find
   allocates extra objects when this really isn't needed.

To work around this the following service fields have been moved to the
database (instead of being hardcoded):

* category
* default

This in turn means we can get the external issue tracker using the
following query:

    SELECT *
    FROM services
    WHERE active IS TRUE
    AND default IS FALSE
    AND category = 'issue_tracker'
    AND project_id = XXX
    LIMIT 1

This coupled with memoizing the result (just as before this commit)
greatly reduces the time it takes for Project#external_issue_tracker to
complete. The exact reduction depends on one's environment, but locally
the execution time is reduced from roughly 230 ms to only 2 ms (= a
reduction of almost 180x).

Fixes gitlab-org/gitlab-ce#10771
2016-01-19 14:03:20 +01:00
Stan Hu
79c0e7212a Annotate models 2016-01-06 13:09:55 +00:00
Kirilll Zaitsev
263abda3fd Drone CI service 2015-09-02 05:52:16 +03:00
Kamil Trzcinski
427b5df260 Added support for CI skipped status 2015-08-04 16:47:19 +02:00
Stan Hu
a3157626f1 Re-annotate models 2015-05-03 13:38:27 -07:00
Valery Sizov
e5fe14b2fb Link to CI with ref 2015-03-20 19:19:29 +02:00
Dmitriy Zaporozhets
66c61f023b Re-annotate models 2015-03-04 14:14:00 -08:00
Douwe Maan
d57e809cbd Set supported events per project service. 2015-03-03 11:14:32 +01:00
Stan Hu
afe5d7d209 Issue #595: Support Slack notifications upon issue and merge request events
1) Adds a DB migration for all services to toggle on push, issue, and merge events.

2) Upon an issue or merge request event, fire service hooks.

3) Slack service supports custom messages for each of these events. Other services
not supported at the moment.

4) Label merge request hooks with their corresponding actions.
2015-03-03 11:14:31 +01:00
Marin Jankovski
b3f944a398 Annotate services. Add a link to service template. 2015-02-11 18:29:24 -08:00
Valery Sizov
82c938ad75 annotate 2014-10-09 18:22:20 +03:00
Drew Blessing
a0dbcd2365 Serialize services properties 2014-09-10 09:56:39 -05:00
Dmitriy Zaporozhets
92deb451da
Annotate models
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-08-25 12:25:02 +03:00
Dmitriy Zaporozhets
a18ae13e98
Backport CI service refactoring from EE
It allows easier contribution of different CI services

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-05-28 11:35:43 +03:00