Sean McGivern
9add8e3a66
Fix wording in Danger warning about MRs to non-master
...
If it's most of the time, then it's not all.
2018-09-04 09:57:22 +01:00
Winnie Hellmann
705da921ba
Drop WIP from changelog command in Danger comment
2018-08-24 20:54:55 +00:00
Rémy Coutable
674882fe5d
Merge branch '49631-fix-dangerfile-schema-rb' into 'master'
...
Resolve "Dangerfile reporting that db/schema.rb wasn't updated"
Closes #49631
See merge request gitlab-org/gitlab-ce!20852
2018-07-26 09:47:40 +00:00
Thong Kuah
8f4745deb4
Fix regexp for detected db/schema.rb and ee/db/geo/schema.rb
2018-07-26 10:31:45 +12:00
Robert Speicher
f5df4976b6
Make the frozen_string Danger check more resilient
...
It's possible for a Ruby file to be empty and thus `gets` returns `nil`.
Also indents the Markdown since we're using `<<~` and removes an
unneeded variable.
2018-07-25 14:32:44 -07:00
gfyoung
db00a9c641
Add Dangerfile for frozen_string_literal
...
Checks that new Ruby files will enable
frozen string literal.
Partially addresses #47424 .
2018-07-24 02:17:45 -07:00
Rémy Coutable
8ce6381f3c
Improve danger/specs/Dangerfile by not requiring new specs if specific labels are applied
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-17 09:43:47 +02:00
Rémy Coutable
3e573142b7
Improve danger/changelog/Dangerfile to include the title in the bin/changelog command
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-17 09:43:46 +02:00
Gabriel Mazetto
9265e76920
Use the correct exceptions to look for invalid YAML in Changelogs
2018-07-13 05:08:45 +02:00
Stan Hu
209b66fb0d
Fix Dangerfile
2018-07-12 01:19:07 -07:00
Robert Speicher
27843cd2e7
Autocorrect RuboCop violations in danger/**/Dangerfile
2018-07-11 14:44:35 -05:00
Rémy Coutable
545c961dbc
Wrap DB paths in backticks in the Danger check
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 19:12:44 +02:00
Yorick Peterse
b851fe8635
Fix "Database Team" typo for Danger
2018-07-11 14:51:48 +02:00
Yorick Peterse
ced15dd531
Tweak the Danger settings for DB changes
...
Instead of only checking for migrations, we now check for a variety of
files and directories that require a database review. We also include
some steps on how to make sure changes are reviewed.
2018-07-11 14:48:31 +02:00
Rémy Coutable
ab87e7bab1
Improve Danger files after first review
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 11:52:03 +02:00
Rémy Coutable
5679837cd4
Start to use Danger for automating MR reviews
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-07-11 11:52:01 +02:00
