gfyoung
e166e5747c
Enable some frozen string in lib/gitlab
...
Enable frozen string for the following files:
* lib/gitlab/auth/**/*.rb
* lib/gitlab/badge/**/*.rb
* lib/gitlab/bare_repository_import/**/*.rb
* lib/gitlab/bitbucket_import/**/*.rb
* lib/gitlab/bitbucket_server_import/**/*.rb
* lib/gitlab/cache/**/*.rb
* lib/gitlab/checks/**/*.rb
Partially addresses #47424 .
2018-10-13 02:31:31 -07:00
Michael Kozono
a54a5d9f39
Use Gitlab::SafeRequestStore in more places
...
Even if it doesn’t save lines of code, since people will tend to use
code they’ve seen. And `SafeRequestStore` is safer since you
don’t have to remember to check `RequestStore.active?`.
2018-09-24 12:11:27 -07:00
Lin Jen-Shin
d5c7fe29c8
Add docs for RequestCache, moved from comments
2018-06-22 18:18:42 +08:00
Lin Jen-Shin
9ac0c76b78
Use StrongMemoize and enable/disable cops properly
2017-11-18 01:01:53 +08:00
Lin Jen-Shin
9ae92b8caa
Add cop to make sure we don't use ivar in a module
2017-09-18 21:23:45 +08:00
Robert Speicher
260c8da060
Whitelist or fix additional Gitlab/PublicSend cop violations
...
An upcoming update to rubocop-gitlab-security added additional
violations.
2017-08-14 12:14:11 -04:00
Lin Jen-Shin
3922b80329
Rename the methods to make it fit with current name
2017-07-18 18:04:20 +08:00
Lin Jen-Shin
ffc5b29bd0
Follow feedback on the merge request
2017-07-18 17:48:48 +08:00
