8346da6527
Add backtraces to Peek performance bar for SQL calls
...
Just as we have backtraces for Gitaly, we should also have backtraces
for SQL calls. This makes it much easier to find the source of the SQL
call and optimize N+1 queries and other performance issues with an
endpoint.
2019-06-09 18:19:40 -07:00
624a1cdab4
Upgrade Rails to 5.1.6.1
...
Model.new.attributes now also returns encrypted attributes.
2019-04-23 08:31:23 +08:00
f93f8f569d
Enable even more frozen string for lib/gitlab
...
Enables frozen string for the following:
* lib/gitlab/patch/**/*.rb
* lib/gitlab/popen/**/*.rb
* lib/gitlab/profiler/**/*.rb
* lib/gitlab/project_authorizations/**/*.rb
* lib/gitlab/prometheus/**/*.rb
* lib/gitlab/query_limiting/**/*.rb
* lib/gitlab/quick_actions/**/*.rb
* lib/gitlab/redis/**/*.rb
* lib/gitlab/request_profiler/**/*.rb
* lib/gitlab/search/**/*.rb
* lib/gitlab/sherlock/**/*.rb
* lib/gitlab/sidekiq_middleware/**/*.rb
* lib/gitlab/slash_commands/**/*.rb
* lib/gitlab/sql/**/*.rb
* lib/gitlab/template/**/*.rb
* lib/gitlab/testing/**/*.rb
* lib/gitlab/utils/**/*.rb
* lib/gitlab/webpack/**/*.rb
Partially addresses gitlab-org/gitlab-ce#47424 .
2018-11-19 18:24:22 -08:00
f107bc69e3
Simplify by using Gitlab::SafeRequestStore
...
These are clear wins.
2018-09-24 12:11:26 -07:00
58058ce0ca
Fix SQL timings for the performance bar
...
My recent change accidentally changed the reported time from
milliseconds to seconds, resulting in wrong timings being displayed.
2017-11-03 15:45:58 +01:00
189b5c3c39
Remove Sherlock usage from the performance bar
...
Sherlock::Query generates a backtrace on every call to "new", which is
very slow. Formatter queries are also not displayed properly due to the
lack of "white-space: pre" in the CSS. We took a look at fixing this,
but the produced output is not really better than just displaying
queries on one line.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/39351
2017-10-23 14:59:07 +03:00
1c7893c5c1
Merge branch 'rc/bump-peek-performance_bar' into 'master'
...
Bump peek-performance_bar to 1.3.0 and get rid of a monkey-patch
See merge request !12939
2017-07-19 08:52:01 +00:00
3dcd3df531
Fix queries duration sorting in Performance Bar
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-18 19:00:46 +02:00
66c7f51897
Bump peek-performance_bar to 1.3.0 and get rid of a monkey-patch
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-18 13:56:36 +02:00
32eaf46ead
Don't track cached queries in Gitlab::PerformanceBar::PeekQueryTracker
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-17 16:44:00 +02:00
0430b76441
Enable Style/DotPosition Rubocop 👮
2017-06-21 13:48:12 +00:00
d1b4576a79
Ensure peek-performance_bar doesn't break existing functionalities
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-09 17:21:39 +02:00
e859145329
Fix Rubocop offenses, improve SQL duration format and changelog entry
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-09 17:21:39 +02:00
651eb51ece
Display queries duration in performance bar queries modal
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-09 17:21:39 +02:00
46273e1446
Store Sherlock::Query in Peek adapter
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-06-09 17:21:39 +02:00
Stan Hu