Commit Graph

26 Commits

Author SHA1 Message Date
Jan Provaznik 1b42c847bc Fix rails 5 deprecation warnings
Fixes rails 5 deprecation warnings in `config/` files
2018-09-11 18:14:37 +02:00
blackst0ne 1499b02f73 [Rails5] Pass class references instead of strings to middleware builder
It fixes Rails 5.0 deprecation flooding like:

```
DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change
them to actual class references.  For example:

  "::Gitlab::Middleware::ReadOnly" => Gitlab::Middleware::ReadOnly

 (called from <top (required)> at /builds/gitlab-org/gitlab-ce/config/environment.rb:11)
DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change
them to actual class references.  For example:

  "ActionDispatch::Static" => ActionDispatch::Static

 (called from <top (required)> at /builds/gitlab-org/gitlab-ce/config/environment.rb:11)
DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change
them to actual class references.  For example:

  "Gitlab::Testing::RequestBlockerMiddleware" => Gitlab::Testing::RequestBlockerMiddleware

 (called from <top (required)> at /builds/gitlab-org/gitlab-ce/config/environment.rb:11)
DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change
them to actual class references.  For example:

  "ActionDispatch::Static" => ActionDispatch::Static

 (called from <top (required)> at /builds/gitlab-org/gitlab-ce/config/environment.rb:11)
DEPRECATION WARNING: Passing strings or symbols to the middleware builder is deprecated, please change
them to actual class references.  For example:

  "Gitlab::Testing::RequestInspectorMiddleware" => Gitlab::Testing::RequestInspectorMiddleware

 (called from <top (required)> at /builds/gitlab-org/gitlab-ce/config/environment.rb:11)
```
2018-06-13 14:12:38 +11:00
blackst0ne 36bedfb7f3 [Rails5] Update files by `rails app:update` 2018-03-22 09:37:57 +11:00
Mike Greiling b612bcfc64
implement basic request inspector for use in Capybara tests 2017-10-23 17:00:41 +03:00
Mike Greiling 7b262c4356 Resolve "Precompiled assets with digest strings are ignored in CI" 2017-10-03 14:47:56 +00:00
Rémy Coutable ba74f38946 Fix logger disabling on the CI: instantiate an ActiveSupport::TaggedLogging
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-20 11:16:12 +02:00
Robert Speicher fc76ff1051 Disable Rails logging in CI test environments
See https://jtway.co/speed-up-your-rails-test-suite-by-6-in-1-line-13fedb869ec4
2017-07-18 12:33:15 -04:00
Stan Hu 00dd2ba95e Turn on caching of classes in Knapsack specs
Enabling caching of classes slows start-up time because all controllers
are loaded at initialization, but it reduces memory and load because files
are not reloaded with every request. For example, caching is not necessary
for loading database migrations but useful for handling Knapsack specs.

Addresses gitlab-org/gitlab-ee#2162
2017-04-14 15:13:31 -07:00
Rémy Coutable 645a55f19b Introduce a new middleware for the test environment that can block requests
The idea is that after each feature spec example, we block all incoming
requests at the Rack level, go to the 'about:blank' page, and wait until
the current requests reach 0.

This should solve the problem where a request would end after database
cleaner performed the database truncation. The problem was that a GET
request can still lead to records creation (e.g. namespaces or routes).

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-22 19:45:21 +01:00
Gabriel Mazetto f5a0ac0fc1 Codestyle: make sure we have space around operators 2016-05-13 04:46:56 -03:00
Robert Speicher 5ff9d2a182 Bump rails to 4.2.6 2016-04-05 13:07:53 -04:00
Rémy Coutable 9c593a51c3 Remove duplicate 'cache_store' configuration in test environment 2016-03-02 10:33:38 +00:00
Douwe Maan 2955ca613b Merge branch 'master' into reference-pipeline-and-caching 2015-12-02 11:20:51 +01:00
Valery Sizov 461731f076 fix notification_service specs 2015-11-30 11:21:10 +02:00
Valery Sizov 7f214cee74 Migrate mailers to ActiveJob 2015-11-26 17:03:43 +02:00
Valery Sizov 40ff1318d2 Rails update to 4.2.4 2015-11-25 18:18:44 +02:00
Douwe Maan f5a630111f Merge branch 'master' into reference-pipeline-and-caching 2015-11-19 15:46:04 +01:00
Valery Sizov 9e0d443f9e Disabling cache for test environment 2015-11-16 12:18:31 +02:00
Douwe Maan c1ecfb5de9 Disabling caching in test environment because it was causing issues with Markdown 2015-10-22 15:38:11 +02:00
Jeroen van Baarsen d458e39e31 Don't cache classes in tests
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-02-12 13:47:23 +01:00
Dmitriy Zaporozhets f86afb732b
Fix dev env. Fix MR creation
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-06-26 18:40:13 +03:00
Jeroen van Baarsen 81fc5137ac Fixed the WhiningNill deprecation fix 2013-12-10 12:11:27 +02:00
Dmitriy Zaporozhets ede272406a Update config/* to rails4
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2013-12-10 12:11:27 +02:00
Riyad Preukschas 527d223680 Update Rails config 2012-11-18 21:51:53 +01:00
Nihad Abbasov 83efcabc82 set activerecord whitelist_attributes to true 2012-09-26 11:18:35 -07:00
gitlabhq 9ba1224867 init commit 2011-10-09 00:36:38 +03:00