Jacopo
0ce6785851
Replaces tag: true into :tag in the specs
...
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
2017-10-07 13:57:54 +02:00
Alejandro Rodríguez
34eeac6108
Use Gitlab::Git's Popen on that module's code
...
This allows the current Gitaly migration to depend on less code outside
of the Gitlab::Git module
2017-09-20 13:21:54 +02:00
Ahmad Sherif
daa0137b41
Migrate force push check to Gitaly
2017-08-11 19:42:17 +02:00
Rémy Coutable
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
Robert Speicher
a6ec5121f0
Correct RSpec/SingleLineHook cop offenses
2017-06-14 13:18:56 -05:00
Michael Kozono
23d37382da
Refactor to let GitAccess errors bubble up
...
No external behavior change.
This allows `GitHttpController` to set the HTTP status based on the type of error. Alternatively, we could have added an attribute to GitAccessStatus, but this pattern seemed appropriate.
2017-06-05 05:32:26 -07:00
Sam Rose
1ebd9dad8e
Add confirm delete protected branch modal
2017-05-08 07:41:58 +00:00
Sean McGivern
5069682d8e
Enable RSpec/FilePath cop
...
- Ignore JS fixtures
- Ignore qa directory
- Rewrite concern specs to put concern name first
2017-04-26 12:50:32 +01:00
James Edwards-Jones
07d7d8e659
Renamed ProtectedTag push_access_levels to create_access_levels
2017-04-04 03:38:58 +01:00
James Edwards-Jones
d5acb69e11
Protected Tags prevents all updates instead of just force pushes.
...
This only changes behaviour for masters, as developers are already prevented from updating/deleting tags without the Protected Tags feature
2017-04-04 00:10:14 +01:00
James Edwards-Jones
bf3cc824e4
Moved Project#protected_branch? to ProtectedBranch, similar for tags
2017-04-03 19:19:54 +01:00
James Edwards-Jones
e3fbcd0093
Protected Tags enforced over git
2017-03-31 19:37:38 +01:00
Adam Niedzielski
47270e1cfd
Backport changes from gitlab-org/gitlab-ee!1406
2017-03-13 12:31:27 +01:00
Robert Speicher
80a6d2fda2
Use :empty_project where possible throughout spec/lib
2017-01-25 12:25:42 -05:00
Rémy Coutable
0b5b3ec3a4
Remove useless permission checks in Gitlab::Checks::ChangeAccess
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-12 17:37:14 -05:00
Timothy Andrew
c937aec1f7
Check the exit code while invoking git in the force push check.
...
Previously, we were calling out to `popen` without asserting on the returned
exit-code. Now we raise a `RuntimeError` if the exit code is non-zero.
2016-12-16 23:32:25 +05:30
Alejandro Rodríguez
2f06027dc3
Change the order of the access rules to check simpler first, and add specs
2016-08-12 18:27:42 -04:00
