3676275a5a
don't rely on order of notification levels
...
factor out #suitable_notification_level? and check manually by
notification level. this makes the notification logic clear and actually
reflect what is in the documentation as to what should happen with each
setting.
2017-08-21 15:34:25 -07:00
38737345ab
skip the :read_project check for new_project_member
...
since we're just adding them as a member, the permission may still
return false.
2017-08-11 16:02:08 -07:00
7e7f602d29
make NotificationRecipient a little more customizable
2017-08-11 16:02:01 -07:00
eaa503d679
move the read_ability logic into NotificationRecipient
2017-08-03 09:07:18 -07:00
e5496e1e8e
use the accessor for `type`
2017-08-03 09:07:18 -07:00
4af2c64713
fix comment
2017-08-03 09:07:18 -07:00
444c858449
use safe navigation on notification_setting
2017-08-03 09:07:18 -07:00
c2dd4239c9
short-circuit if there is no policy, and add :read_project check
2017-08-03 09:07:18 -07:00
18288fe21e
style fixes
2017-08-03 09:07:18 -07:00
e7d136ebda
don't require project
...
it's not there in the case of personal snippets, f. ex., and we've
already guarded against its being missing in #find_notification_setting
2017-08-03 09:07:18 -07:00
19309b9705
default the project to target.project
2017-08-03 09:07:18 -07:00
618a3d125c
move Recipient to its own NotificationRecipient file
2017-08-03 09:07:18 -07:00
http://jneen.net/