Commit Graph

5 Commits

Author SHA1 Message Date
GitLab Release Tools Bot b0f939a79f Merge branch 'security-ag-hide-private-members-in-project-member-autocomplete' into 'master'
Hide private members in project member autocomplete

See merge request gitlab/gitlabhq!3212
2019-10-29 15:58:31 +00:00
GitLab Bot 587794b4b8 Add latest changes from gitlab-org/gitlab@master 2019-10-02 00:06:26 +00:00
Aakriti Gupta 506bf42817 Pick only those groups that the viewing user has access to,
in a project members' list. Add tests for possible scenarios

Re-factor and remove N + 1 queries

Remove author from changelog

Don't use memoisation when not needed

Include users part of parents of project's group

Re-factor tests

Create and add users according to roles

Re-use group created earlier

Add incomplete test for ancestoral groups

Rename method to clarify category of groups

Skip pending test, remove comments not needed

Remove extra line

Include ancestors from invited groups as well

Add specs for participants service

Add more specs

Add more specs

use  instead of

Use public group owner instead of project maintainer to test owner acess

Remove tests that have now been moved into participants_service_spec

Use :context instead of :all

Create nested group instead of creating an ancestor separately

Add comment explaining doubt on the failing spec

Imrpove test setup

Optimize sql queries

Refactor specs file

Add rubocop disablement

Add special case for project owners

Add small refactor

Add explanation to the docs

Fix wording

Refactor group check

Add small changes in specs

Add cr remarks

Add cr remarks

Add specs

Add small refactor

Add code review remarks

Refactor for better database usage

Fix failing spec

Remove rubocop offences

Add cr remarks
2019-09-25 13:24:45 +02:00
Felipe Artur 7e83acb8a2 Prevent disclosing project milestone titles
Prevent unauthorized users having access to milestone titles
through autocomplete endpoint.
2019-02-25 10:55:15 -03:00
Luke Bennett aa464800b8
Add type property to project autocomplete members 2019-02-18 16:58:28 +00:00