Commit Graph

20 Commits

Author SHA1 Message Date
Camil Staps 86eae7b2e0
Fix public/private/internal fork counts 2019-09-06 09:51:04 +02:00
Markus Koller db132bae1d
Support redirect paths starting with a dash
We use a leading dash for certain things like the WebIDE, which
had the side effect of losing the `params[:continue][:to]` param when
opening the WebIDE on a project where the user doesn't have push access
and therefore needs to fork the project first.
2019-06-25 13:19:30 +02:00
gfyoung 93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
blackst0ne b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Lin Jen-Shin 4ee08b77bc Updates from `rubocop -a` 2018-07-09 21:13:08 +08:00
Lin Jen-Shin ab286656b2 Resolve "Namespace factory is problematic" 2018-04-23 15:48:26 +00:00
blackst0ne 27c95364b5 Replace '.team << [user, role]' with 'add_role(user)' in specs 2017-12-22 19:18:28 +11:00
Jacopo 2f40dac352 Refactor `have_http_status` into `have_gitlab_http_status` in the specs 2017-10-20 10:13:18 +02:00
Robert Speicher a6ec5121f0 Correct RSpec/SingleLineHook cop offenses 2017-06-14 13:18:56 -05:00
Douwe Maan ad640bc5f9 Use Namespace#full_path instead of #path where appropriate 2017-02-23 17:55:01 -06:00
Robert Speicher 4642ca6686 Use `empty_project` where possible in controller specs 2017-01-25 17:14:38 -05:00
Cagdas Gerede 5bc19dec54 Remove newlines between context and it in addition to testing redirection for create action to import path 2016-11-15 21:23:20 +03:00
Cagdas Gerede 5f2d45c956 Add authentication for for create action. Add more tests for for new and create actions 2016-11-15 01:59:11 +03:00
Cagdas Gerede 37cad72970 Move sign_out out of it into before 2016-11-13 03:12:35 +03:00
Earth 2c55d8167b Replace tabs with spaces 2016-11-13 03:05:26 +03:00
Earth f080cb5316 Add a unit test for redirecting to sign-in page when user is not logged in and user visits the new fork page 2016-11-13 02:59:43 +03:00
tiagonbotelho 519275c110 fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
Grzegorz Bizon 9e211091a8 Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
Robert Speicher b900304c38 Make better use of the `visibility_level` factory traits 2016-03-08 16:40:45 -05:00
Rubén Dávila 49e4ef3b41 Add specs to ForksController#index.
* Also refactor query to get projects accessible for current user.
  ProjectsFinder actually return public projects when no user is passed.
2016-03-02 12:35:56 -05:00