Commit Graph

6 Commits

Author SHA1 Message Date
GitLab Bot 775816e676 Add latest changes from gitlab-org/gitlab@master 2020-01-10 00:07:56 +00:00
GitLab Bot 669c24d927 Add latest changes from gitlab-org/gitlab@master 2020-01-06 09:07:42 +00:00
GitLab Bot fb73ca3398 Add latest changes from gitlab-org/gitlab@master 2019-12-27 15:08:16 +00:00
GitLab Bot 9865665cb1 Add latest changes from gitlab-org/gitlab@master 2019-10-08 12:06:01 +00:00
Drew Blessing 7f00bcb92e Allow CI to clone public projects when HTTP protocol is disabled
GitLab has a mechanism that allows CI to clone repositories via HTTP
even when the HTTP protocol is disabled. This works as expected
when a project is private or internal. However, when a project is
public CI gets an error message that HTTP is not allowed. This
happens because Git only sends auth in a subsequent request after a
401 is returned first. For public projects, GitLab grabs onto that
unauthenticated request and sends it through since it recognizes
that Guests are ordinarily allowed to access the repository.
Later on this leads to a 403 since HTTP protocol is disabled.
Fix this by only continuing with unauthenticated requests when
HTTP is allowed.
2019-08-14 14:15:33 -05:00
Stan Hu d165754400 Reject HEAD requests to info/refs endpoint
In production, we see high error rates due to clients attempting to use
the dumb Git HTTP protocol with HEAD /foo/bar.git/info/refs
endpoint. This isn't supported and causes Error 500s because Workhorse
doesn't send along its secret because it's not proxying this request.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54579
2019-03-19 11:23:51 -07:00