Commit graph

9 commits

Author SHA1 Message Date
Lin Jen-Shin
a0990ff356 Simplify CreateDeploymentService so that it uses
methods directly from job, avoid duplicating the works.
2017-06-01 21:01:32 +08:00
Kamil Trzcinski
43906336ff Fix tests and add has_environment? 2016-11-17 12:08:28 +01:00
Kamil Trzcinski
d6e00f5373 Improve specs and add missing cases that were not supported 2016-11-17 00:23:05 +01:00
Kamil Trzcinski
c70acb57f5 Expose last_deployment on Ci::Builds [ci skip] 2016-11-08 16:50:03 -06:00
Yorick Peterse
97731760d7
Re-organize queues to use for Sidekiq
Dumping too many jobs in the same queue (e.g. the "default" queue) is a
dangerous setup. Jobs that take a long time to process can effectively
block any other work from being performed given there are enough of
these jobs.

Furthermore it becomes harder to monitor the jobs as a single queue
could contain jobs for different workers. In such a setup the only
reliable way of getting counts per job is to iterate over all jobs in a
queue, which is a rather time consuming process.

By using separate queues for various workers we have better control over
throughput, we can add weight to queues, and we can monitor queues
better. Some workers still use the same queue whenever their work is
related. For example, the various CI pipeline workers use the same
"pipeline" queue.

This commit includes a Rails migration that moves Sidekiq jobs from the
old queues to the new ones. This migration also takes care of doing the
inverse if ever needed. This does require downtime as otherwise new jobs
could be scheduled in the old queues after this migration completes.

This commit also includes an RSpec test that blacklists the use of the
"default" queue and ensures cron workers use the "cronjob" queue.

Fixes gitlab-org/gitlab-ce#23370
2016-10-21 18:17:07 +02:00
Grzegorz Bizon
3726dc4bb7 Check if project exists before creating deployment 2016-10-14 10:19:16 +02:00
Grzegorz Bizon
4e9342599b Fix typo in build success worker for deployment 2016-10-13 15:24:33 +02:00
Grzegorz Bizon
8efa041a73 Do not process build success if project was removed 2016-10-13 14:56:32 +02:00
Grzegorz Bizon
204fdcb1ab Add build success worker that runs asynchronously 2016-10-13 12:58:25 +02:00