Commit Graph

22 Commits

Author SHA1 Message Date
GitLab Bot 8c826685ec Add latest changes from gitlab-org/gitlab@master 2020-06-02 09:08:01 +00:00
GitLab Bot e689e858ed Add latest changes from gitlab-org/gitlab@master 2020-05-13 18:08:47 +00:00
GitLab Bot e33f87ac0f Add latest changes from gitlab-org/gitlab@master 2020-04-21 15:21:10 +00:00
GitLab Bot abae8f34f3 Add latest changes from gitlab-org/gitlab@master 2020-03-31 21:08:05 +00:00
GitLab Bot 571d993b49 Add latest changes from gitlab-org/gitlab@master 2020-01-15 18:08:34 +00:00
GitLab Bot 90a06a20be Add latest changes from gitlab-org/gitlab@master 2019-11-07 15:06:33 +00:00
Vitali Tatarintev 69dbc5a527 Remove Rubocop::SpecHelper file 2019-08-28 08:48:14 +02:00
Vitali Tatarintev 17385f4dc4 Refactor BeSuccessMatcher specs for readability 2019-08-28 08:43:47 +02:00
Vitali Tatarintev 99b27e6951 Utilize Rubocop's Include for BeSuccessMatcher
Use Rubocop's Include
instead of manually checking the matcher in controllers specs.
2019-08-28 08:43:47 +02:00
Vitali Tatarintev b61d26f496 Add support of not_to/to_not to BeSuccessMatcher
BeSuccessMatcher now supports following examples:

```
expect(response).to be_success
expect(response).to_not be_success
expect(response).not_to be_success

is_expected.to be_success
is_expected.to_not be_success
is_expected.not_to be_success
```
2019-08-28 08:43:47 +02:00
Vitali Tatarintev e1b8b93207 Replace double quotes with single quotes 2019-08-28 08:43:47 +02:00
Vitali Tatarintev d40b7ea375 Enable frozen string literal 2019-08-28 08:43:47 +02:00
Vitali Tatarintev 3a71ab523e Autocorrect `be_success` to `be_successful` 2019-08-28 08:43:47 +02:00
Vitali Tatarintev 4f2ac51644 Add Rubocop check to avoid using `be_success`
Prevent using `be_success` call in controller specs to avoid
getting following deprecation warning:

```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
2019-08-28 08:43:47 +02:00
Peter Leitzen e101a26444 Utilize RuboCop's Include/Exclude config
Stop checking the file location programmatically.
2019-08-26 12:24:25 +00:00
Sean McGivern ab0a6455c7 Add RSpec/TopLevelDescribePath cop
The RSpec/FilePath cop checks that a spec file's path is correct, but
only if the file describes a constant. We want to check, for any file
with a top-level `describe`, whether the file path ends in
`_spec.rb`. We don't care what comes before that; just that it will be
executed by RSpec at all.
2019-08-01 11:07:26 +01:00
Rémy Coutable 4b035896c4
Introduce a new FactoriesInMigrationSpecs cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-04-06 17:41:52 +02:00
Rémy Coutable a2d39b8010 Use gitlab-styles
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-12-22 08:34:44 -06:00
Rémy Coutable 8a31b07437 Add a new RSpec::EnvAssignment cop to prevent assigning to ENV in specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-10-18 18:42:09 +02:00
Jacopo 0ce6785851 Replaces `tag: true` into `:tag` in the specs
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
2017-10-07 13:57:54 +02:00
Robert Speicher c5a88df6b7 Require rubocop-rspec in the correct location
Resolves the `codeclimate` CI failure
2017-06-14 17:08:34 -05:00
Robert Speicher 69ad827e82 Add a custom RSpec/SingleLineHook cop
This cop adds an offense when `before`, `after`, or `around` are used as
single-line blocks.
2017-06-14 13:16:44 -05:00