Commit Graph

21 Commits

Author SHA1 Message Date
Fatih Acet 1413c94a8e Merge branch '15081-wrong-login-tab-ldap-frontend' into 'master'
Fixed Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists

## What does this MR do?
Fixes issue: 15081 Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists
This is done by saving into a cookie when the active tab changes and by always selecting that tab when the page is loaded.
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
In order to fix the issue: 15081
## Screenshots (if relevant)

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?


Closes #15081

See merge request !7314
2016-12-09 09:17:41 +00:00
Mike Greiling 4f107f3fc4 refactor Diff to es6 class syntax 2016-12-02 17:38:57 -06:00
Jacopo 8235f83015 Fixed Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists
When ldap is enabled and use "Standard" authentication method, if authentication fails
the correct tab remain selected.
This is done by saving into localStorage when the active tab changes and by always selecting that tab when
the page is loaded.
2016-12-02 10:19:31 +01:00
Fatih Acet 629624f30f Merge branch '24814-pipeline-tabs' into 'master'
Pipelines tabs

## What does this MR do?
Changes the URL when the builds tab is clicked making it possible to be shared.

1. Adds a standard way to handle linked tabs:
    *   This behaviour is already present in the merge requests, commit and user `show` page. 
    *    This MR introduces a reusable way to accomplish this behaviour for pages with static content.

2. Adds test:
    *   For the linked tabs reusable class
    *  For the pipelines tabs

## Why was this MR needed?
To allow having a sharable URL that represented the opened tab

![tabs](/uploads/91e663c12c6e9ac46a17aa3a9489dc72/tabs.gif)

## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
Closes #24814

See merge request !7709
2016-12-01 21:20:59 +00:00
Mike Greiling a167897bed move wiki navbar content to right sidebar 2016-11-30 15:22:43 -06:00
Filipa Lacerda aa2d6eec9e Improvements after review 2016-11-30 17:06:48 +00:00
Filipa Lacerda cc4434a483 Fix after review
Adds require statement
2016-11-30 17:06:47 +00:00
Stan Hu a43f71ec14 Hide project variables values by default
Add a button to reveal/hide the values to help prevent accidental
disclosure of sensitive information from wandering on a page.

Closes #21358
2016-11-24 00:21:48 -08:00
Jacob Schatz d17f506811 Merge branch '23449-cycle-analytics-2-frontend' into 'master'
Cycle analytics second iteration frontend

## Are there points in the code the reviewer needs to double check?
Mostly typos and code guidelines.

## Why was this MR needed?
This implements the frontend part of !6859 for #23449

## Screenshots

**Initial view**
![Screen_Shot_2016-11-21_at_5.28.43_PM](/uploads/ff9cfa9c9d6c2da28c24e03e384f89af/Screen_Shot_2016-11-21_at_5.28.43_PM.png)

**Cycle Analytics with data**
![Screen_Shot_2016-11-21_at_2.09.24_PM](/uploads/18d9786c090bdd554cf786c879543302/Screen_Shot_2016-11-21_at_2.09.24_PM.png)

**User doesn't have access for a stage**
![Screen_Shot_2016-11-21_at_2.11.01_PM](/uploads/d1ea76a63f2de2224954b5f40038c488/Screen_Shot_2016-11-21_at_2.11.01_PM.png)

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
Closes #23449

See merge request !7366
2016-11-22 00:16:13 +00:00
Alfredo Sumaran 6f824b156f Improve first implementation 2016-11-21 13:49:18 -05:00
Mike Greiling ed88515d56 convert activities.js to es6 class syntax 2016-11-20 01:32:20 -06:00
Luke Bennett ac7efb2916
Removed inline JS and added new affix declaration
Tidied up UX

Corrected naming convention issues with removing inline JS

@deckar01 saves the day! Simplified `toggleSidebar` and `hideSidebar`

Review changes

Merge conflicts and update autoscroll button
2016-11-04 15:07:51 +00:00
Bryce Johnson d939fbed09 Change show-gl-field-errors to gl-show-field-errors 2016-11-02 11:35:21 +01:00
winniehell 02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Luke Bennett 3ea3a6a152 invoked the pipelines class when builds are dynamically loaded and dispatched for commit builds page 2016-10-24 13:20:37 -05:00
Douglas Barbosa Alexandre 52e0c3b565 Add CRUD for Group Labels 2016-10-19 14:57:15 -02:00
Alfredo Sumaran a975e4cb34 Merge branch 'master' into merge-conflicts-editor-2 2016-10-17 12:17:12 -05:00
Bryce Johnson 039ccc169a Convert due_date_select.js filetype to es6. 2016-10-17 11:58:03 +02:00
Sean McGivern 86dcb79be3 Merge branch 'master' into merge-conflicts-editor-2 2016-10-17 10:56:55 +01:00
Bryce Johnson 716406bc71 Back off the array spreading, bc poltergeist freaks out. 2016-10-15 08:28:55 +02:00
Bryce Johnson eb866dfe05 Convert dispatcher to es6. 2016-10-15 08:28:55 +02:00