- Use multiple threads / database connections to:
1. Escape the transaction the spec seems to be running
in (`config.use_transactional_fixtures` is off, but
`ActiveRecord::Base.connection.open_transactions` is not empty
at the beginning of the spec.
2. Simulate a Sidekiq worker performing the hard delete outside of the
soft-delete transaction.
- The spec is a little clunky, but it was the smallest thing I could get
working - and even this took a couple of hours. Let me know if you
have any suggestions to improve it!
There is a race condition in DestroyGroupService now that projects are deleted asynchronously:
1. User attempts to delete group
2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project
3. DestroyGroupService destroys the Group, leaving all its projects without a namespace
4. Projects::DestroyService runs later but the can?(current_user,
:remove_project) is `false` because the user no longer has permission to
destroy projects with no namespace.
5. This leaves the project in pending_delete state with no namespace/group.
Projects without a namespace or group also adds another problem: it's not possible to destroy the container
registry tags, since container_registry_path_with_namespace is the wrong value.
The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService.
Closes#17893
