gfyoung
ddca49e4b5
Enable frozen string in apps/uploaders/*.rb
...
Partially addresses #47424 .
2018-07-16 06:41:59 -07:00
Lin Jen-Shin
07d3d44775
Move ModuleWithInstanceVariables to Gitlab namespace
...
And use .rubocop.yml to exclude paths we don't care,
rather than using the cop itself to exclude.
2017-11-22 17:06:57 +08:00
Lin Jen-Shin
9ac0c76b78
Use StrongMemoize and enable/disable cops properly
2017-11-18 01:01:53 +08:00
Lin Jen-Shin
6a4ee9aa71
Allow simple ivar ||= form. Update accordingly
2017-09-19 01:29:32 +08:00
Lin Jen-Shin
9ae92b8caa
Add cop to make sure we don't use ivar in a module
2017-09-18 21:23:45 +08:00
Oswaldo Ferreira
d730b69eb2
Spam check only when spammable attributes have changed
2017-03-21 14:20:15 -03:00
Oswaldo Ferreira
2ace39f242
Spam check and reCAPTCHA improvements
2017-02-21 13:32:49 -03:00
Patricio Cano
43e756d4ea
Refactored AkismetHelper into AkismetService and cleaned up Spammable
...
- Refactored SpamCheckService into SpamService
2016-08-15 13:18:15 -05:00
Patricio Cano
64ab2b3d9f
Refactored spam related code even further
...
- Removed unnecessary column from `SpamLog`
- Moved creation of SpamLogs out of its own service and into SpamCheckService
- Simplified code in SpamCheckService.
- Moved move spam related code into Spammable concern
2016-08-15 13:18:15 -05:00
Patricio Cano
722fc84e3d
Complete refactor of the Spammable concern and tests:
...
- Merged `AkismetSubmittable` into `Spammable`
- Clean up `SpamCheckService`
- Added tests for `Spammable`
- Added submit (ham or spam) options to `AkismetHelper`
2016-08-15 13:18:15 -05:00
Patricio Cano
f01fce7f46
Refactor spam validation to a concern that can be easily reused and improve legibility in SpamCheckService
2016-07-26 19:29:16 -05:00
Patricio Cano
8f04cf0ead
Refactor SpamCheckService to make it cleaner and clearer.
2016-07-26 15:18:07 -05:00
