Commit graph

13 commits

Author SHA1 Message Date
Alexandru Croitor
c99402c05f
Add policy check if cross reference system notes are accessible 2019-09-30 14:22:05 +02:00
Heinrich Lee Yu
9f67b886b2
Prevent award_emoji to notes not visible to user
When the parent noteable is not visible to the user (e.g. confidential)
we prevent the user from adding emoji reactions to notes
2019-01-31 16:51:17 +01:00
Cindy Pallares
e122e14ac6
Merge branch 'security-guest-comments' into 'master'
[master]Fixed ability to comment on and edit/delete comments on locked or confidential issues

See merge request gitlab/gitlabhq!2612
2018-11-28 19:11:56 -05:00
gfyoung
d5bf57a6af Enable frozen string in presenters and policies
Enable frozen string in:

* app/presenters
* app/policies

Partially addresses #47424.
2018-07-24 13:18:25 -07:00
Bob Van Landuyt
04c7d0d555 Prevent awarding emoji when a project is archived
This prevents performing the requests, and disables all emoji reaction buttons
2018-04-11 10:51:43 +02:00
Douwe Maan
8272ec9a76 Update policies to make archived projects completely read-only 2018-04-10 15:46:20 +02:00
Douwe Maan
267a909600 Remove edit_note and update_note abilities in favor of admin_note 2018-04-10 15:46:20 +02:00
Jarka Kadlecova
994e7d1359 Create system notes for MR too, improve doc + clean up code 2017-09-14 14:50:32 +02:00
Jarka Kadlecova
2b82f907ab Check the discussion lock only for issuables & clean style 2017-09-14 14:50:32 +02:00
Jarka Kadlecova
b928720852 Support discussion locking in the backend 2017-09-14 14:50:32 +02:00
http://jneen.net/
37c401433b convert all the policies to DeclarativePolicy 2017-06-27 12:44:37 -07:00
Rydkin Maxim
170efaaba2 Enable Style/MultilineOperationIndentation in Rubocop, fixes #25741 2016-12-16 21:37:22 +03:00
http://jneen.net/
d87c1d550f port notes and project snippets 2016-08-30 11:39:22 -07:00