5 Commits

Author	SHA1	Message	Date
Thong Kuah	4ec16912b8	Autocorrect with RSpec/ExampleWording cop ... - rewords examples starting with 'should' - rewords examples starting with 'it' Note: I had to manually fixup "onlies" to "only"	2019-04-05 08:43:27 +00:00
Mayra Cabrera	b3364566c4	Fixes technical debt issues for cluster domain ... - Avoid using direct code on spec migration - Removes milestone and point to issue, to avoid making fake promises Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57397	2019-02-07 11:11:22 -06:00
Mayra Cabrera	087af654bb	Addresses backend/db review comments ... - Fixes multiple typos on AutoDevops script - Add an alias to Clusters::Cluster#domain as base_domain, so it's more descriptive - Removes unnecessary memoization on qa specs - Changes migration to a post migration to deal better with traffic on big instances (like gitlab.com)	2019-02-04 12:08:09 -06:00
Mayra Cabrera	8b5553daa4	Use a single sql statement for ADO query ... Since cluster_projects table does not have a lot of records, currently it has 11,638, it seems better to use a single sql statement to update all the records	2019-02-04 11:43:35 -06:00
Mayra Cabrera	8ff73614a1	Moves domain setting to Cluster setting ... Changes domain field to be on the Cluster page show, removing it from Auto DevOps setting. Also injects the new environment variable KUBE_INGRESS_BASE_DOMAIN into kubernetes#predefined_variables. Migration to move the information from ProjectAutoDevops#domain to Clusters::Cluster#domain. As well as necessary modifications to qa selectors Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52363	2019-02-04 11:43:34 -06:00